Update builds controller to use getPreferredVersion #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Sep 20, 2017
app/scripts/controllers/builds.js
Outdated
| Logger, | ||
| $location, | ||
| BuildsService, | ||
| ProjectsService) { |
There was a problem hiding this comment.
Let's sort the dependencies to keep the lists manageable
There was a problem hiding this comment.
sort done
benjaminapetersen
force-pushed
the
bpetersen/trello-api-groups-builds
branch
from
60d9848 to
efea61c
Compare
|
Yeah, this one didn't need a view update as there are no |
spadgett
reviewed
Sep 25, 2017
app/scripts/controllers/builds.js
Outdated
| @@ -20,6 +30,9 @@ angular.module('openshiftConsole') | |||
|
|
|||
| var buildConfigForBuild = $filter('buildConfigForBuild'); | |||
|
|
|||
| $scope.buildsVersion = APIService.getPreferredVersion('builds'); | |||
| $scope.buildConfigsVersion = APIService.getPreferredVersion('buildconfigs'); | |||
There was a problem hiding this comment.
Let's not use $scope vars if these aren't used in the view
There was a problem hiding this comment.
sounds good. kept that for consistency with other views, but agree, no point in blowing up $scope.
benjaminapetersen
force-pushed
the
bpetersen/trello-api-groups-builds
branch
from
efea61c to
4d0f64a
Compare
|
updated |
spadgett
approved these changes
Sep 25, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 4d0f64a |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/260/) (Base Commit: 6dde77e) (PR Branch Commit: 4d0f64a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spadgett