Update CreatePersistentVolumeClaimController to use getPreferredVersion #2160

benjaminapetersen · 2017-09-25T17:33:10Z

No view updates.

spadgett · 2017-09-25T18:21:16Z

app/scripts/controllers/createPersistentVolumeClaim.js

@@ -24,6 +25,8 @@ angular.module('openshiftConsole')
    $scope.accessModes="ReadWriteOnce";
    $scope.claim = {};

+    var perpersistentVolumeClaimsVersion = APIService.getPreferredVersion('buildconfigs');


s/buildconfigs/persistentvolumeclaims

thx @spadgett, updating

benjaminapetersen · 2017-09-25T18:31:58Z

updated.

spadgett · 2017-09-25T18:39:34Z

app/scripts/controllers/createPersistentVolumeClaim.js

@@ -24,6 +25,8 @@ angular.module('openshiftConsole')
    $scope.accessModes="ReadWriteOnce";
    $scope.claim = {};

+    var perpersistentVolumeClaimsVersion = APIService.getPreferredVersion('persistentvolumeclaims');


oh good grief, not cool. ok, my review process sucks. lemme fix my system, sorry ☹️

To be fair, I missed that on first review :)

at least var name consistently wrong but not broken, heh.... Updating.

benjaminapetersen · 2017-09-25T18:54:35Z

ok updated w/fixed var name.

Version is not updated in the resource body we POST

spadgett

Hey @benjaminapetersen Missed this on first review, but we shouldn't use the preferred version for create. We should use the version in the object body that we construct. That should be updated to use the API group.

benjaminapetersen · 2017-09-25T19:48:49Z

Updated w/objectToResourceGroupVersion.

spadgett · 2017-09-25T20:01:30Z

app/scripts/controllers/createPersistentVolumeClaim.js

@@ -49,7 +52,7 @@ angular.module('openshiftConsole')
      .then(_.spread(function(project, context) {
        $scope.project = project;

-        if (!AuthorizationService.canI('persistentvolumeclaims', 'create', $routeParams.project)) {
+        if (!AuthorizationService.canI(persistentVolumeClaimsVersion, 'create', $routeParams.project)) {


We should be checking the same resourceGroupVersion that we create

Yeah that makes sense. Let me update.

benjaminapetersen · 2017-09-26T13:51:56Z

updated

spadgett · 2017-09-26T13:58:28Z

app/scripts/controllers/createPersistentVolumeClaim.js

+      kind: "PersistentVolumeClaim",
+      apiVersion: "v1",
+      metadata: {
+        name: $scope.claim.name,


$scope.claim.name is not set at this point.

Oop, thx, fixed & tested.

benjaminapetersen · 2017-09-27T14:19:21Z

updated

spadgett · 2017-09-27T14:25:53Z

app/scripts/controllers/createPersistentVolumeClaim.js

@@ -59,7 +75,8 @@ angular.module('openshiftConsole')
          if ($scope.createPersistentVolumeClaimForm.$valid) {
            $scope.disableInputs = true;
            var claim = generatePersistentVolumeClaim();
-            DataService.create('persistentvolumeclaims', null, claim, context)
+            var createClaimVersion = APIService.objectToResourceGroupVersion(claim);


I'd use the createPVCVersion from above since we already have it

Yeah doesn't really make sense to do the work again, should still have the same rgv value. I'll update.

Going to move it up as well, most of these I have near the top of the file, before the ProjectService.get()

benjaminapetersen · 2017-09-27T14:59:31Z

Updated/retested.

spadgett · 2017-09-27T15:01:34Z

[merge]

spadgett · 2017-09-27T16:48:55Z

flake #1684

[merge]

openshift-bot · 2017-09-27T16:55:44Z

Evaluated for origin web console merge up to eb19bc2

openshift-bot · 2017-09-27T16:55:55Z

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/278/) (Base Commit: 0177053) (PR Branch Commit: eb19bc2)

spadgett requested changes Sep 25, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from 1ee46ca to 30e2807 Compare September 25, 2017 18:31

spadgett reviewed Sep 25, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from 30e2807 to b5e2aec Compare September 25, 2017 18:53

spadgett previously approved these changes Sep 25, 2017

View reviewed changes

spadgett requested changes Sep 25, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from b5e2aec to 909e639 Compare September 25, 2017 19:46

spadgett reviewed Sep 25, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from 909e639 to 4910f8d Compare September 26, 2017 13:51

spadgett requested changes Sep 26, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from 4910f8d to 8b7d4c4 Compare September 27, 2017 14:18

spadgett reviewed Sep 27, 2017

View reviewed changes

benjaminapetersen force-pushed the bpetersen/trello/api-groups/create-pvc branch from 8b7d4c4 to eb19bc2 Compare September 27, 2017 14:58

Update CreatePersistentVolumeClaimController to use getPreferredVersion

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: C3C9E95F03B681FE

Learn about vigilant mode

eb19bc2

spadgett approved these changes Sep 27, 2017

View reviewed changes

openshift-bot merged commit b09dafe into openshift:master Sep 27, 2017

benjaminapetersen deleted the bpetersen/trello/api-groups/create-pvc branch September 27, 2017 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CreatePersistentVolumeClaimController to use getPreferredVersion #2160

Update CreatePersistentVolumeClaimController to use getPreferredVersion #2160

benjaminapetersen commented Sep 25, 2017

spadgett Sep 25, 2017

benjaminapetersen Sep 25, 2017

benjaminapetersen commented Sep 25, 2017

spadgett Sep 25, 2017

benjaminapetersen Sep 25, 2017

spadgett Sep 25, 2017

benjaminapetersen Sep 25, 2017

benjaminapetersen commented Sep 25, 2017

spadgett left a comment

benjaminapetersen commented Sep 25, 2017

spadgett Sep 25, 2017

benjaminapetersen Sep 25, 2017

benjaminapetersen commented Sep 26, 2017

spadgett Sep 26, 2017

benjaminapetersen Sep 27, 2017

benjaminapetersen commented Sep 27, 2017

spadgett Sep 27, 2017

benjaminapetersen Sep 27, 2017 •

edited

Loading

benjaminapetersen Sep 27, 2017

benjaminapetersen commented Sep 27, 2017 •

edited

Loading

spadgett commented Sep 27, 2017

spadgett commented Sep 27, 2017

openshift-bot commented Sep 27, 2017

openshift-bot commented Sep 27, 2017 •

edited

Loading

Update CreatePersistentVolumeClaimController to use getPreferredVersion #2160

Update CreatePersistentVolumeClaimController to use getPreferredVersion #2160

Conversation

benjaminapetersen commented Sep 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 25, 2017

spadgett left a comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 27, 2017

Choose a reason for hiding this comment

benjaminapetersen Sep 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Sep 27, 2017 • edited Loading

spadgett commented Sep 27, 2017

spadgett commented Sep 27, 2017

openshift-bot commented Sep 27, 2017

openshift-bot commented Sep 27, 2017 • edited Loading

benjaminapetersen Sep 27, 2017 •

edited

Loading

benjaminapetersen commented Sep 27, 2017 •

edited

Loading

openshift-bot commented Sep 27, 2017 •

edited

Loading