Skip to content

Removing orphaned tech-preview less and markup #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Removing orphaned tech-preview less and markup #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
</head>
<body class="console-os" ng-class="{ 'has-project-bar': view.hasProject }">
<!-- Add your site or application content here -->
<p ng-if="globalTechPreviewIndicator" ng-cloak class="tech-preview-banner">Technology preview is enabled</p>
<osc-header></osc-header>
<toast-notifications></toast-notifications>
<notification-drawer-wrapper></notification-drawer-wrapper>
Expand Down
6 changes: 0 additions & 6 deletions app/styles/_catalog.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
.landing {
@media(min-width: @screen-sm-min) {
top: (@navbar-os-header-height-desktop + @landing-search-area-height);
.tech-preview & {
top: (@navbar-os-header-height-desktop + @tech-preview-banner-height + @landing-search-area-height);
}
}
h1, .nav-tabs {
margin-bottom: 0 !important;
Expand All @@ -24,8 +21,5 @@
.catalog-search,
.landing-side-bar {
top: @navbar-os-header-height-desktop;
.tech-preview & {
top: @navbar-os-header-height-desktop + @tech-preview-banner-height;
}
}
}
12 changes: 0 additions & 12 deletions app/styles/_layouts.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,13 @@
body {
height: 1px;
padding-top: @navbar-os-header-height-mobile;
&.tech-preview {
padding-top: (@navbar-os-header-height-mobile + @tech-preview-banner-height);
}
@media(min-width: @screen-sm-min) {
padding-top: @navbar-os-header-height-desktop;
&.tech-preview {
padding-top: (@navbar-os-header-height-desktop + @tech-preview-banner-height);
}
}
&.has-project-bar {
padding-top: (@navbar-os-header-height-mobile + @project-bar-height-mobile);
&.tech-preview {
padding-top: (@navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height);
}
@media(min-width: @screen-sm-min) {
padding-top: (@navbar-os-header-height-desktop + @project-bar-height-desktop);
&.tech-preview {
padding-top: (@navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height);
}
.container-pf-nav-pf-vertical {
margin-left: @nav-pf-vertical-width;
&.collapsed-nav {
Expand Down
12 changes: 0 additions & 12 deletions app/styles/_log.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,6 @@
top: (@log-scroll-offset-top + @navbar-os-header-height-desktop);
}
}
.tech-preview & {
top: (@log-scroll-offset-top + @navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height);
@media (min-width: @screen-sm-min) {
top: (@log-scroll-offset-top + @navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height);
}
}
.tech-preview .chromeless & {
top: (@log-scroll-offset-top + @navbar-os-header-height-mobile + @tech-preview-banner-height);
@media (min-width: @screen-sm-min) {
top: (@log-scroll-offset-top + @navbar-os-header-height-desktop + @tech-preview-banner-height);
}
}
}
}
.log-view-output {
Expand Down
3 changes: 0 additions & 3 deletions app/styles/_navbar-vertical.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
vertical-align: middle;
width: 0;
}
.layout-pf-fixed .tech-preview & {
top: @tech-preview-banner-height;
}
.navbar-brand {
padding: 0;
@media(min-width: @screen-sm-min) {
Expand Down
8 changes: 0 additions & 8 deletions app/styles/_notifications.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ notification-drawer-wrapper {
&.hide-remove {
display: block !important;
}
.tech-preview & {
height: calc(100vh ~"-" (@navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height));
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height);
@media(min-width: @screen-sm-min) {
height: calc(100vh ~"-" (@navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height) ~"-" 20px); // 20px bottom gutter
top: (@navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height);
}
}
}
// the whole block is clickable, need to set pointer on all of these
// for the correct visual
Expand Down
6 changes: 0 additions & 6 deletions app/styles/_project-bar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,4 @@
background-color: @navbar-pf-vertical-color;
}
}
.tech-preview & {
top: @navbar-os-header-height-mobile + @tech-preview-banner-height;
@media (min-width: @screen-sm-min) {
top: @navbar-os-header-height-desktop + @tech-preview-banner-height;
}
}
}
15 changes: 0 additions & 15 deletions app/styles/_tech-preview.less
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/styles/_variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
@scrollbar-width: 15px;
@status-bg-color: #E6ECF1;
@status-border-color: #BFCEDB;
@tech-preview-banner-height: 20px;
@tileHeadingIconFontSize: 33px;
@tooltip-bg: #111;

Expand Down
18 changes: 0 additions & 18 deletions app/styles/_vertical-nav.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,6 @@
}
}
}
.tech-preview & {
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height);
@media(min-width: @screen-sm-min) {
top: (@navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height);
}
}
}
.nav-item-pf-header {
font-size: (@font-size-base + 1);
Expand All @@ -144,16 +138,4 @@
padding: 4px 0 2px 0;
margin-left: 20px;
}
.tech-preview & {
top: (@navbar-os-header-height-mobile + @tech-preview-banner-height);
@media(min-width: @screen-sm-min) {
top: (@navbar-os-header-height-desktop + @tech-preview-banner-height);
}
}
.tech-preview.has-project-bar & {
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile + @tech-preview-banner-height);
@media(min-width: @screen-sm-min) {
top: (@navbar-os-header-height-desktop + @project-bar-height-desktop + @tech-preview-banner-height);
}
}
}
1 change: 0 additions & 1 deletion app/styles/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
@import "_system-status.less";
@import "_tables.less";
@import "_tile.less";
@import "_tech-preview.less";
@import "_tooltip.less";
@import "_typography.less";
@import "_spacers.less";
Expand Down
1 change: 0 additions & 1 deletion dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<style type="text/css"></style>
</head>
<body class="console-os" ng-class="{ 'has-project-bar': view.hasProject }">
<p ng-if="globalTechPreviewIndicator" ng-cloak class="tech-preview-banner">Technology preview is enabled</p>
<osc-header></osc-header>
<toast-notifications></toast-notifications>
<notification-drawer-wrapper></notification-drawer-wrapper>
Expand Down
Loading