Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align hover and expanded list-group-item bg colors with list-pf #2339

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Align hover and expanded list-group-item bg colors with list-pf #2339

merged 1 commit into from
Oct 23, 2017

Conversation

rhamilto
Copy link
Member

PatternFly deprecated list-view, so the hover and expanded bg colors
are still the old standard. This fix remedies that until we can update
the monitoring page to use list-pf (I will open a separate tech debt
issue for that).
screen shot 2017-10-23 at 9 40 09 am
screen shot 2017-10-23 at 9 40 15 am

@rhamilto rhamilto requested a review from spadgett October 23, 2017 13:48
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2017
@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2017
@spadgett
Copy link
Member

Hm, Jenkins is complaining about the dist, but it passed Travis. @rhamilto can you try rebasing and rebuilding?

PatternFly deprecated list-view, so the hover and expanded bg colors
are still the old standard.  This fix remedies that until we can update
the monitoring page to use list-pf (I will open a separate tech debt
issue for that).
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2017
@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 6c32d53 into openshift:master Oct 23, 2017
@rhamilto rhamilto deleted the monitoring-row-hover-color branch October 23, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants