Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust spacing around 'Events' heading in sidebar on monitoring page #2418

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Adjust spacing around 'Events' heading in sidebar on monitoring page #2418

merged 1 commit into from
Nov 1, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Nov 1, 2017

In #2389 I adjusted the spacing around the h1 so borders aligned, but I overlooked the border underneath "Events" in the monitoring page sidebar. This fixes that, and does so in a way that the border is consistent across browsers (it wasn't before--only Chrome had a correctly aligned border).

Before:
screen shot 2017-11-01 at 10 46 26 am

After:
screen shot 2017-11-01 at 10 46 01 am

@rhamilto rhamilto requested a review from spadgett November 1, 2017 14:49
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2017
@spadgett
Copy link
Member

spadgett commented Nov 1, 2017

/kind bug
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Nov 1, 2017
@serenamarie125
Copy link

@rhamilto
Should Events & View Details be bottom aligned? Looks like View Details is a pixel or two higher

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 431a311 into openshift:master Nov 1, 2017
@rhamilto
Copy link
Member Author

rhamilto commented Nov 1, 2017

Should Events & View Details be bottom aligned? Looks like View Details is a pixel or two higher

Probably. Lemme see what's going on there. :)

@rhamilto rhamilto deleted the monitoring-sidebar-heading branch November 1, 2017 17:23
@rhamilto rhamilto mentioned this pull request Nov 1, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Nov 1, 2017
@openshift-merge-robot
Merge pull request #2425 from rhamilto/monitoring-view-details
0bb17eb 
Automatic merge from submit-queue.

Fix vertical alignment of "View Details" link

Fixes #2418 (comment)

![screen shot 2017-11-01 at 1 40 45 pm](https://user-images.githubusercontent.com/895728/32288685-17cd5fbc-bf0b-11e7-9f72-d1104244568a.PNG)
With a guide for validation
![screen shot 2017-11-01 at 1 40 36 pm](https://user-images.githubusercontent.com/895728/32288686-17df6ffe-bf0b-11e7-99e5-c2586c43525c.PNG)

cc: @serenamarie125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhamilto @spadgett @serenamarie125 @openshift-merge-robot @openshift-ci-robot