Skip to content

Add watcher to secrets page #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

Add watcher to secrets page #2421

merged 1 commit into from
Nov 1, 2017

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Nov 1, 2017

@spadgett PTAL

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 1, 2017
@jhadvig jhadvig requested a review from spadgett November 1, 2017 15:56
spadgett
spadgett approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhadvig We're also not calling watchObject on the individual secret page, but I think it makes to do that a follow up.

LGTM thanks

@spadgett
Copy link
Member

spadgett commented Nov 1, 2017

/kind bug
/lgtm

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Nov 1, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit c0e7f37 into openshift:master Nov 1, 2017
@jhadvig jhadvig mentioned this pull request Nov 2, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Nov 4, 2017
@openshift-merge-robot
Merge pull request #2436 from jhadvig/secret-watcher
ee5a6b2 
Automatic merge from submit-queue.

Add watcher to secrets browse page

This is a follow up of #2421

@spadgett PTAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhadvig @spadgett @openshift-merge-robot @openshift-ci-robot