Don't request isimage more than once on page load #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
changed the title
|
We can still get into race situations if we are say coming back from editing a DC, because the watch updates will fire more requests to get the ImageStreamImage |
jwforres
approved these changes
Sep 20, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 5b97c7c |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/414/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwforres The watch callback happens almost immediately after the get callback in the browse pages, which means we were calling
fetchReferencedImageStreamImagesa second time before the first call completed. I changed the code to just call it from the watch, and removed some unecessary$scopevars. PTALPartially addresses #548