Bug fix 1389239 - Hang due to undefined object when no storage class … #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Oct 27, 2016
| @@ -78,7 +78,7 @@ angular.module('openshiftConsole') | |||
| var unit = $scope.claim.unit || "Mi"; | |||
| pvc.spec.resources.requests.storage = $scope.claim.amount + unit; | |||
| pvc.spec.selector.matchLabels = keyValueEditorUtils.mapEntries( keyValueEditorUtils.compactEntries($scope.claim.selectedLabels) ); | |||
| if ($scope.claim.storageClass !== null) { | |||
| if ( typeof($scope.claim.storageClass ) !== "undefined" && $scope.claim.storageClass !== null ) { | |||
There was a problem hiding this comment.
Can we simply check
if ($scope.claim.storageClass) { ... }
There was a problem hiding this comment.
@spadgett - that still does not seem to handle the undefined case which occurs when the user chooses no storage class
There was a problem hiding this comment.
When $scope.claim.storageClass is undefined, that if will evaluate to false.
|
@spadgett - On further testing, that does work for all cases. Code updated. Thanks. |
spadgett
approved these changes
Oct 27, 2016
|
[merge] |
|
Evaluated for origin web console merge up to cd83986 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/590/) (Base Commit: 8fa3e93) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hang due to undefined object when no storage class is selected