Bug 1333101 Use long date format on logs to remove ambiguity in month vs day #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spadgett PTAL |
spadgett
reviewed
Nov 15, 2016
| @@ -123,9 +123,9 @@ | |||
| <span class="space-after">{{build.status.phase}}</span> | |||
|
|
|||
| <div ng-if="build.status.startTimestamp && !logEmpty" class="log-timestamps"> | |||
| Log from {{build.status.startTimestamp | date : 'short'}} | |||
| Log from {{build.status.startTimestamp | date : 'MMM dd, yyyy h:mm a'}} | |||
There was a problem hiding this comment.
Should we use date : 'medium' which is the almost the same, but will be localized?
There was a problem hiding this comment.
agreed, updating the other places we were using this
jwforres
force-pushed
the
long-date-format
branch
from
1d5da15 to
e07e2be
Compare
jwforres
force-pushed
the
long-date-format
branch
from
e07e2be to
008ff70
Compare
|
@spadgett updated everything to use medium |
spadgett
approved these changes
Nov 15, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 008ff70 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 008ff70 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/693/) (Base Commit: d0a5912) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/712/) (Base Commit: 91841a7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1333101