prevent secret modal from closing on outside click #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the "backdrop" for the "create new secret" modal static, so that the modal is not accidentally closed if a click is made outside of it. This enforces the use of the "cancel" button on the modal in order to close it.
spadgett
approved these changes
Nov 17, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 6df8e4c |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 6df8e4c |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/714/) (Base Commit: 91841a7) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/717/) (Base Commit: cf48ed9) |
juanvallejo
deleted the
jvallejo/prevent-new-secrets-modeal-from-closing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1390490
This patch makes the "backdrop" for the "create new secret" modal
static, so that the modal is not accidentally closed if a click is made
outside of it. This enforces the use of the "cancel" button on the modal
in order to close it.
Path to modal: https://localhost:9000/project/lo/edit/builds/`name of your bc
> click onadvanced options> click oncreate new secret`@jwforres