Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1333162 Improve descriptions for quota scopes #887

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Bug 1333162 Improve descriptions for quota scopes #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/scripts/filters/resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,10 +1233,10 @@ angular.module('openshiftConsole')
})
.filter('scopeDetails', function(sentenceCaseFilter) {
var scopeMessages = {
"Terminating": "Matches pods that have an active deadline.",
"NotTerminating": "Matches pods that do not have an active deadline.",
"BestEffort": "Matches pods that have best effort quality of service.",
"NotBestEffort": "Matches pods that do not have best effort quality of service."
"Terminating": "Affects pods that have an active deadline. These pods usually include builds, deployers, and jobs.",
"NotTerminating": "Affects pods that do not have an active deadline. These pods usually include your applications.",
"BestEffort": "Affects pods that do not have resource limits set. These pods have a best effort quality of service.",
"NotBestEffort": "Affects pods that have at least one resource limit set. These pods do not have a best effort quality of service."
};
return function(scope) {
return scopeMessages[scope] || sentenceCaseFilter(scope);
Expand Down
8 changes: 4 additions & 4 deletions dist/scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13263,10 +13263,10 @@ return a.readinessProbe || a.livenessProbe;
};
}).filter("scopeDetails", [ "sentenceCaseFilter", function(a) {
var b = {
Terminating:"Matches pods that have an active deadline.",
NotTerminating:"Matches pods that do not have an active deadline.",
BestEffort:"Matches pods that have best effort quality of service.",
NotBestEffort:"Matches pods that do not have best effort quality of service."
Terminating:"Affects pods that have an active deadline. These pods usually include builds, deployers, and jobs.",
NotTerminating:"Affects pods that do not have an active deadline. These pods usually include your applications.",
BestEffort:"Affects pods that do not have resource limits set. These pods have a best effort quality of service.",
NotBestEffort:"Affects pods that have at least one resource limit set. These pods do not have a best effort quality of service."
};
return function(c) {
return b[c] || a(c);
Expand Down