Skip to content

Replacing generic cubes icon with custom-icon directive #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Replacing generic cubes icon with custom-icon directive #890

merged 1 commit into from
Nov 18, 2016

Conversation

rhamilto
Copy link
Member

on create/fromimage and create/fromtemplate pages so that the image or template-specific icons display instead.

Resolves openshift/origin#3432

A few examples:

screen shot 2016-11-18 at 11 39 54 am
screen shot 2016-11-18 at 11 40 15 am
screen shot 2016-11-18 at 11 40 27 am
screen shot 2016-11-18 at 11 40 45 am
screen shot 2016-11-18 at 11 40 59 am
screen shot 2016-11-18 at 11 41 14 am

@jwforres or @spadgett, PTAL.

on create/fromimage and create/fromtemplate pages

Resolves openshift/origin#3432
@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to bfda078

@openshift-bot
Copy link

openshift-bot commented Nov 18, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/724/) (Base Commit: ca4be23)

@openshift-bot openshift-bot merged commit 29241d5 into openshift:master Nov 18, 2016
@rhamilto rhamilto deleted the issue-3432 branch November 18, 2016 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants