Update karma to run both firefox & chrome tests

[benjaminapetersen]

Updating Karma to run both tests in both Firefox & Chrome concurrently:

• Firefox is much more valuable since we all tend to use Chrome
• Chrome, however, has much better error messages that make you less likely to throw yourself out the window while writing tests.

@jwforres @spadgett

[jwforres]

This has to be optional. From my testing a few months ago Chrome does not work well inside a container, which means its probably not going to work well in Travis either. Our tests have to be runnable inside a container for when we move to testing all of our stuff on openshift itself

[jwforres]

With most of us developing in Chrome anyway, I'm not sure we get much benefit from running the spec tests in Chrome.

[benjaminapetersen]

• Right, let me see if I can make it optional
• Agree, I'd rather always run them in Firefox or any non-chrome. During dev though, Firefox's error reporting is inferior, switching to Chrome is much easier to debug (only reason I did this).

[benjaminapetersen]

how about this? can now set the browser else default to FF:

browsers=Chrome grunt test

[jwforres]

you should do that with a grunt option not an environment variable for consistency with how we do all of our options

[benjaminapetersen]

tried that, grunt doesn't exist in the karma.conf.js file. Wasn't sure if I should import grunt into that file & use grunt.options('browser'). Thoughts?

[jwforres]

looks like you can override anything in the config file in the Gruntfile https://github.com/karma-runner/grunt-karma#heres-an-example-that-puts-the-config-in-the-gruntfile

[benjaminapetersen]

Aha, I tried this in karma.conf.js:

    karma: {
      unit: {
        configFile: 'test/karma.conf.js',
        singleRun: true,
        browsers: grunt.options('browsers') ? [grunt.options('browsers')] : ['Firefox']
      }
    },

But it doesn't work cuz no grunt. Started to import, then realized I should prob do this in gruntfile.js instead:

    karma: {
      unit: {
        configFile: 'test/karma.conf.js',
        singleRun: true,
        // defaulting to Firefox for running tests, but recommend Chrome for writing
        // tests due to better error messages:
        //      grunt test --browsers=Chrome
        browsers: grunt.option('browsers') ? [grunt.option('browsers')] : ['Firefox']
      }
    }

Seems better?

[jwforres]

Yeah generally looks like the right direction to me.
But that doesn't look like it would work correctly if multiple browsers
were specified, if you are only supporting 1 browser running then make the
flag browser (not plural)

On Mon, Nov 21, 2016 at 2:52 PM, Ben Petersen [email protected]
wrote:

Aha, I tried this in karma.conf.js:

karma: {
  unit: {
    configFile: 'test/karma.conf.js',
    singleRun: true,
    browsers: grunt.options('browsers') ? [grunt.options('browsers')] : ['Firefox']
  }
},

But it doesn't work cuz no grunt. Started to import, then realized I
should prob do this in gruntfile.js instead:

karma: {
  unit: {
    configFile: 'test/karma.conf.js',
    singleRun: true,
    // defaulting to Firefox for running tests, but recommend Chrome for writing
    // tests due to better error messages:
    //      grunt test --browsers=Chrome
    browsers: grunt.option('browsers') ? [grunt.option('browsers')] : ['Firefox']
  }
}

Seems better?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#894 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7eQiZD8Gyy5jll8DSC_goYaCgASlks5rAfZzgaJpZM4K2wUp
.

[benjaminapetersen]

😄
yeah, have been trying to figure out multiple, not quite there yet.

[jwforres]

i'd probably just go with comma separated and do a string split if the
option exists

On Mon, Nov 21, 2016 at 3:03 PM, Ben Petersen [email protected]
wrote:

😄
yeah, have been trying to figure out multiple, not quite there yet.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#894 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7d6RLcxGlQli3AJ8zT006ShbkVcVks5rAfkigaJpZM4K2wUp
.

[benjaminapetersen]

Nice, that works, no quiry 'multiple options for grunt.options()' needed.

grunt test
grunt test --browsers=Chrome
grunt test --browsers=Chrome,Firefox

[jwforres]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to c6f3267

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/750/) (Base Commit: 23682f1)