Updating annotations directive to always display Show/Hide Annotation…

[rhamilto]

…s link

and adding message “There are no annotations on this resource.” if
there are no annotations.

Resolves openshift/origin#7643

Always show link

If no annotations, display message

If annotations, show annotations

@jwforres, PTAL

[spadgett]

Should we have the message instead of the "Show annotations" link when there are none?

[jwforres]

Personally I thought having the message just hanging out would be more
strange than it appearing

On Nov 18, 2016 2:34 PM, "Sam Padgett" [email protected] wrote:

Should we have the message instead of the "Show annotations" link when
there are none?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7afKaKEIh7SBAwGYMd57PGxmxdHGks5q_f26gaJpZM4K20EP
.

[rhamilto]

Why are we hiding annotations anyway?

[spadgett]

Why are we hiding annotations anyway?

They're usually system fields, sometimes with large values like JSON blobs

[jwforres]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to a7df440

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/730/) (Base Commit: 402dd22)