Skip to content

Updates to make spacing beneath middle header and ui-tabs consistent. And ... #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Nov 21, 2016

... several misc changes for consistency.

Applied margin-bottom: 20px to .middle-header and nav-tabs so consistent spacing is present. Removed margin-top from nav-tabs and .gutter-top class to prevent double spacing. Then addressed special cases as needed... log-header, registry-image-pull, pod-metrics

Misc changes for uniformity

  • Moved pipelines heading markup into .middle-header
  • Changed "Config" tab heading to "Configuration" on /browse/images/
  • Moved deploy-config paused alert to be above tabs so that it's visible from any tab state on that section.
  • Changed secondary headings on /browse/secrets/ to h2 for consistency with /browse/storage/

Fixes #878

screen shot 2016-11-21 at 12 56 45 pm

@sg00dwin sg00dwin force-pushed the header-and-tabs-spacing branch from 9e9724d to 537ab3a Compare November 21, 2016 19:19
@spadgett
Copy link
Member

[merge]

@spadgett spadgett self-assigned this Nov 21, 2016
@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 537ab3a

@openshift-bot
Copy link

openshift-bot commented Nov 22, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/756/) (Base Commit: 95b0902)

@openshift-bot openshift-bot merged commit b0c62bb into openshift:master Nov 22, 2016
@sg00dwin sg00dwin deleted the header-and-tabs-spacing branch November 23, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants