Improve guidance when there are no pipelines to show #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
the deploy button shows up if we are able to find the sample pipeline template, which is configurable through our extension Constants. It goes straight to the template deploying page for the sample. |
jwforres
force-pushed
the
no-pipelines
branch
from
16c94c6 to
e7ddd57
Compare
|
Tweaked the spacing within the paragraph
|
|
Awesome! |
spadgett
reviewed
Nov 30, 2016
| var sampleNamespace = Constants.SAMPLE_PIPELINE_TEMPLATE.namespace; | ||
| DataService.get("templates", sampleName, {namespace: sampleNamespace}, {errorNotification: false}).then( | ||
| function() { | ||
| $scope.deploySampleURL = "project/" + $scope.projectName + "/create/fromtemplate?name=" + encodeURIComponent(sampleName) + "&namespace=" + encodeURIComponent(sampleNamespace); |
There was a problem hiding this comment.
We should use Navigate.fromTemplateURL. Then this won't need to change when the parameter names change in #884
| Add to Project | ||
| <p ng-if="(project.metadata.name | canIAddToProject) && deploySampleURL"> | ||
| <a ng-href="{{deploySampleURL}}" class="btn btn-lg btn-primary"> | ||
| Deploy Sample Pipeline |
There was a problem hiding this comment.
Is "Create Sample Pipeline" better?
jwforres
force-pushed
the
no-pipelines
branch
from
e7ddd57 to
482ae3a
Compare
|
updated based on feedback [merge] |
|
Evaluated for origin web console merge up to 482ae3a |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/777/) (Base Commit: 14fe437) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932