Consistently headline case inline action links #978

spadgett · 2016-12-02T20:39:20Z

We sometimes use headline case and sometimes sentence case for inline action links and links in alerts. Consistently use ~~sentence~~ headline case throughout the console.

Fixes #865
See also #805

@jwforres OK with this change? I don't have a strong opinion about headline vs sentence, but I'd like to be consistent.

jwforres · 2016-12-02T20:54:33Z

@spadgett does the patternfly terminology doc specify? @ajacobs21e do you have a preference? this means "View Log" vs "View log"

spadgett · 2016-12-02T20:56:59Z

Note that sometimes they're longer like "Don't show me again" or "Reload environment variables"

spadgett · 2016-12-02T20:59:41Z

It's not clear to me these links fall into any of the categories on the Patternfly terminology page

http://www.patternfly.org/styles/terminology-and-wording

ajacobs21e · 2016-12-02T21:06:31Z

PF uses headline case. I can link to the documentation tomorrow

…

On Fri, Dec 2, 2016 at 3:59 PM, Sam Padgett ***@***.***> wrote: It's not clear to me these links fall into any of the categories on the Patternfly terminology page http://www.patternfly.org/styles/terminology-and-wording — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#978 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGHlfjufo09q4_Y7_6C2evPOFmyCaE3Sks5rEIa9gaJpZM4LC94j> .

-- Allie Jacobs UXD calendar <https://www.google.com/calendar/b/1/[email protected]&ctz=America/New_York>

spadgett · 2016-12-02T21:25:38Z

Should "Show advanced routing, build, deployment and source options" be headline as well?

spadgett · 2016-12-02T21:26:57Z

Probably the longest one:

jwforres · 2016-12-02T21:36:08Z

i think the ones that are more than about 3 words get terrible to read when in headline case

ajacobs21e · 2016-12-05T15:24:54Z

@spadgett @jwforres here are two examples of using Headline Case in PatternFly
https://blog.patternfly.org/lets-talk-more-about-labels/#Link
http://www.patternfly.org/pattern-library/forms-and-controls/expand-collapse-section/#/api
In most cases these links should be only a few words and Headline.

For the long example, we could edit the text or change it to a sentence (like the Links section here http://www.patternfly.org/styles/terminology-and-wording/)
Some options:

Show Advanced Options
Make a header for "Source, Routing, Build, and Deployment Options" with a link below "Show Advanced Options"
Show < Advanced options > for source, routing, build, and deployment settings.

spadgett · 2016-12-05T15:40:42Z

@jwforres @ajacobs21e

spadgett · 2016-12-05T16:50:34Z

Updated links to headline case.

jwforres · 2016-12-05T16:56:47Z

app/scripts/controllers/build.js

@@ -162,7 +162,7 @@ angular.module('openshiftConsole')
              !$filter('canI')('builds/log', 'get')) {
            return [{
              href: Navigate.resourceURL(build),
-              label: "View Build"
+              label: "View build"


I think you need to remove this change

jwforres · 2016-12-05T16:57:45Z

app/views/browse/build-config.html

@@ -153,11 +153,11 @@
                        <span ng-if="latestBuild | buildLogURL">
                          <!-- Always show a log link for pipeline builds. -->
                          <span ng-if="latestBuild | isJenkinsPipelineStrategy">
-                            <a ng-href="{{latestBuild | buildLogURL}}" target="_blank">View Log</a>
+                            <a ng-href="{{latestBuild | buildLogURL}}" target="_blank">View log</a>


revert this and the one right below

jwforres · 2016-12-05T16:59:41Z

app/views/directives/_build-pipeline-links.html

@@ -1 +1 @@
-<div ng-if="(build | buildLogURL) && ('builds/log' | canI : 'get')" class="pipeline-link"><a ng-href="{{build | buildLogURL}}" target="_blank">View Log</a></div>
+<div ng-if="(build | buildLogURL) && ('builds/log' | canI : 'get')" class="pipeline-link"><a ng-href="{{build | buildLogURL}}" target="_blank">View log</a></div>


spadgett · 2016-12-05T17:34:02Z

@jwforres thanks, updated

jwforres · 2016-12-05T17:38:07Z

LGTM then, will let you decide how to order this and #985

jwforres · 2016-12-05T17:38:44Z

just saw your comment in the other PR [merge]

openshift-bot · 2016-12-05T17:39:07Z

Evaluated for origin web console merge up to 3ac1443

openshift-bot · 2016-12-05T17:39:16Z

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/802/) (Base Commit: 8bca523)

spadgett force-pushed the inline-action-case branch from adc42cb to 4f09bc4 Compare December 5, 2016 16:47

spadgett changed the title ~~Consistently sentence case inline action links~~ Consistently headline case inline action links Dec 5, 2016

jwforres reviewed Dec 5, 2016

View reviewed changes

spadgett mentioned this pull request Dec 5, 2016

Let users define labels when creating routes #985

Merged

Change inline actions to consistently use headline case

3ac1443

spadgett force-pushed the inline-action-case branch from 4f09bc4 to 3ac1443 Compare December 5, 2016 17:33

jwforres approved these changes Dec 5, 2016

View reviewed changes

openshift-bot merged commit 6cbd1a7 into openshift:master Dec 5, 2016

spadgett deleted the inline-action-case branch December 5, 2016 17:56

This was referenced Dec 6, 2016

Display Lifecycle hooks on the DC browse page #966

Merged

Headline case more actions #1015

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistently headline case inline action links #978

Consistently headline case inline action links #978

spadgett commented Dec 2, 2016 •

edited

Loading

jwforres commented Dec 2, 2016

spadgett commented Dec 2, 2016

spadgett commented Dec 2, 2016

ajacobs21e commented Dec 2, 2016 via email

spadgett commented Dec 2, 2016

spadgett commented Dec 2, 2016

jwforres commented Dec 2, 2016

ajacobs21e commented Dec 5, 2016

spadgett commented Dec 5, 2016

spadgett commented Dec 5, 2016

jwforres Dec 5, 2016

jwforres Dec 5, 2016

jwforres Dec 5, 2016

spadgett commented Dec 5, 2016

jwforres commented Dec 5, 2016

jwforres commented Dec 5, 2016

openshift-bot commented Dec 5, 2016

openshift-bot commented Dec 5, 2016 •

edited

Loading

		@@ -1 +1 @@
		<div ng-if="(build \| buildLogURL) && ('builds/log' \| canI : 'get')" class="pipeline-link"><a ng-href="{{build \| buildLogURL}}" target="_blank">View Log</a></div>
		<div ng-if="(build \| buildLogURL) && ('builds/log' \| canI : 'get')" class="pipeline-link"><a ng-href="{{build \| buildLogURL}}" target="_blank">View log</a></div>

Consistently headline case inline action links #978

Consistently headline case inline action links #978

Conversation

spadgett commented Dec 2, 2016 • edited Loading

jwforres commented Dec 2, 2016

spadgett commented Dec 2, 2016

spadgett commented Dec 2, 2016

ajacobs21e commented Dec 2, 2016 via email

spadgett commented Dec 2, 2016

spadgett commented Dec 2, 2016

jwforres commented Dec 2, 2016

ajacobs21e commented Dec 5, 2016

spadgett commented Dec 5, 2016

spadgett commented Dec 5, 2016

jwforres Dec 5, 2016

Choose a reason for hiding this comment

jwforres Dec 5, 2016

Choose a reason for hiding this comment

jwforres Dec 5, 2016

Choose a reason for hiding this comment

spadgett commented Dec 5, 2016

jwforres commented Dec 5, 2016

jwforres commented Dec 5, 2016

openshift-bot commented Dec 5, 2016

openshift-bot commented Dec 5, 2016 • edited Loading

spadgett commented Dec 2, 2016 •

edited

Loading

openshift-bot commented Dec 5, 2016 •

edited

Loading