Adjust pipeline-stage widths to accommodate more stages based on browser widths #987
Conversation
|
I think it's better.
Do we still collapse down to one column with vertical arrows at mobile? |
| @@ -145,8 +145,11 @@ | |||
| text-align: center; | |||
| } | |||
| // hide arrow on last stage | |||
| &:last-child:before { | |||
| display: none; | |||
| &:last-child { | |||
There was a problem hiding this comment.
Do you feel strongly about this change? I prefer to avoid unnecessary nesting...
There was a problem hiding this comment.
that actually wasn't meant to be included.
| @@ -261,7 +264,7 @@ | |||
| .pipeline .pipeline-stage { | |||
| padding-right: (@pipeline-padding * 5.2); | |||
| padding-bottom: (@pipeline-padding + 5); | |||
| width: 50%; | |||
| width: calc(100% / 2); | |||
There was a problem hiding this comment.
Curious: Why use calc() over letting the Less do the math?
There was a problem hiding this comment.
no preference really, if it's better to use Less for the math, I'll change.
There was a problem hiding this comment.
In this instance, I prefer to just let the Less do the math since the addition of calc doesn't gain us anything, but it's not a big deal either way.
There was a problem hiding this comment.
I'd prefer to use less for the math
sg00dwin
force-pushed
the
pipeline-stage-issue925
branch
from
faefb47 to
635658a
Compare
|
@spadgett |
| @@ -146,7 +146,7 @@ | |||
| } | |||
| // hide arrow on last stage | |||
| &:last-child:before { | |||
| display: none; | |||
| display: none; | |||
sg00dwin
force-pushed
the
pipeline-stage-issue925
branch
from
635658a to
d226fc5
Compare
|
[merge] |
[merge] |
|
Evaluated for origin web console merge up to d226fc5 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/811/) (Base Commit: 99070c1) |
Fixes #925
Changes to allow space for more stages to fit inline before wrapping.
Current number of stages within single row before wrapping.
Proposed number of stages within single row before wrapping.
Stage widths are percentages. The least number of character spaces before the ellipsis is 20 and a
title attributeis added to stage name and shown on hover.4 stages when > 992px
5 stages when > 1200px
6 stages when > 1400px
7 stages when > 1600px
