Skip to content

Commit e5b4a1c

Browse files
Merge pull request #15906 from pravisankar/fix-stale-comment
Automatic merge from submit-queue (batch tested with PRs 15896, 15921, 15909, 15911, 15906) Update stale comment: We use colon instead of underscore between name… …space and route name for uniquely identifying the route in the router
2 parents 8221c1a + 76edd6d commit e5b4a1c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/router/template/router.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -551,10 +551,10 @@ func (r *templateRouter) routeKey(route *routeapi.Route) string {
551551
name := controller.GetSafeRouteName(route.Name)
552552

553553
// Namespace can contain dashes, so ${namespace}-${name} is not
554-
// unique, use an underscore instead - ${namespace}_${name} akin
554+
// unique, use an underscore instead - ${namespace}:${name} akin
555555
// to the way domain keys/service records use it ala
556556
// _$service.$proto.$name.
557-
// Note here that underscore (_) is not a valid DNS character and
557+
// Note here that colon (:) is not a valid DNS character and
558558
// is just used for the key name and not for the record/route name.
559559
// This also helps the use case for the key used as a router config
560560
// file name.

0 commit comments

Comments
 (0)