Allow running extended test without specifying namespace #11320
Conversation
|
[testextended][extended:core(prune images)] |
| @@ -41,7 +41,7 @@ var _ = g.Describe("[images] prune images", func() { | |||
| o.Expect(err).NotTo(o.HaveOccurred()) | |||
|
|
|||
| g.By(fmt.Sprintf("give a user %s a right to prune images with %s role", oc.Username(), "system:image-pruner")) | |||
| err = oc.AsAdmin().Run("adm").Args("policy", "add-cluster-role-to-user", "system:image-pruner", oc.Username()).Execute() | |||
| err = oc.AsAdmin().NoNamespace().Run("adm").Args("policy", "add-cluster-role-to-user", "system:image-pruner", oc.Username()).Execute() | |||
There was a problem hiding this comment.
I would prefer SetNamespace("") instead of having an extra method.
There was a problem hiding this comment.
We already have SetNamespace but that sets the namespace, which results in passing empty string, which means default namespace.
There was a problem hiding this comment.
got it, and we don't want to break that. I will name it WithNoNamespace() then but that is a minor nit
| fmt.Sprintf("--config=%s", c.configPath), | ||
| }...), | ||
| } | ||
| if !c.noNamespace { |
There was a problem hiding this comment.
just check if len(c.Namespace()) == 0
|
LGTM |
| @@ -41,7 +41,7 @@ var _ = g.Describe("[images] prune images", func() { | |||
| o.Expect(err).NotTo(o.HaveOccurred()) | |||
|
|
|||
| g.By(fmt.Sprintf("give a user %s a right to prune images with %s role", oc.Username(), "system:image-pruner")) | |||
| err = oc.AsAdmin().Run("adm").Args("policy", "add-cluster-role-to-user", "system:image-pruner", oc.Username()).Execute() | |||
| err = oc.AsAdmin().NoNamespace().Run("adm").Args("policy", "add-cluster-role-to-user", "system:image-pruner", oc.Username()).Execute() | |||
|
[test] |
1 similar comment
|
[test] |
|
Evaluated for origin test up to 9f6c430 |
|
Evaluated for origin testextended up to 9f6c430 |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/597/) (Base Commit: 3ed3b35) (Extended Tests: core(prune images)) |
|
[merge] |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10166/) (Base Commit: 3ed3b35) |
|
Flake #11442. re-[merge] |
|
Evaluated for origin merge up to 9f6c430 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10298/) (Base Commit: 7405f17) (Image: devenv-rhel7_5209) |
Fixes #11305
@mfojtik @bparees fyi
@miminar ptal