Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdn: garbage-collect dead containers to recover IPAM leases #11983

Merged

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Nov 21, 2016

Cherry-pick of #11964 to release-1.4

dcbw added 2 commits November 21, 2016 10:40
We don't actually need the netns for IPAM teardown, so don't bother
passing it.  Also ensure we can release an IPAM allocation even
when the container has already died, in case kubelet didn't call
the plugin in this case.
@dcbw
Copy link
Contributor Author

dcbw commented Nov 21, 2016

@openshift/networking @knobunc

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@knobunc
Copy link
Contributor

knobunc commented Nov 21, 2016

[test]

@knobunc
Copy link
Contributor

knobunc commented Nov 21, 2016

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e35ddb3

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11611/) (Base Commit: b4e0954)

@knobunc
Copy link
Contributor

knobunc commented Nov 21, 2016

Known, unrelated, flake: #11685

All relevant tests passed. [merge]

@knobunc
Copy link
Contributor

knobunc commented Nov 22, 2016

[merge] flaked #10988

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e35ddb3

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11647/) (Base Commit: b4e0954) (Image: devenv-rhel7_5404)

@openshift-bot openshift-bot merged commit 55728ad into openshift:release-1.4 Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants