-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdn: garbage-collect dead containers to recover IPAM leases #11983
sdn: garbage-collect dead containers to recover IPAM leases #11983
Conversation
We don't actually need the netns for IPAM teardown, so don't bother passing it. Also ensure we can release an IPAM allocation even when the container has already died, in case kubelet didn't call the plugin in this case.
Port of kubernetes/kubernetes#35572 to openshift-sdn. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1395183
@openshift/networking @knobunc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
[test] |
Evaluated for origin test up to e35ddb3 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11611/) (Base Commit: b4e0954) |
Known, unrelated, flake: #11685 All relevant tests passed. [merge] |
[merge] flaked #10988 |
Evaluated for origin merge up to e35ddb3 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11647/) (Base Commit: b4e0954) (Image: devenv-rhel7_5404) |
Cherry-pick of #11964 to release-1.4