Avoid reloads when route configuration hasn't changed #12242
Conversation
|
[test] |
marun
force-pushed
the
router-reload-only-when-changed
branch
3 times, most recently
from
543f3a5 to
077863b
Compare
|
Phenomenal
|
marun
force-pushed
the
router-reload-only-when-changed
branch
from
077863b to
c4636aa
Compare
|
@smarterclayton I want to get this into a 3.4 maintenance release too. |
|
flake #12184 re-[test] |
|
|
||
| // routeKeys returns the internal router keys to use for the given Route. | ||
| // A route can have several services that it can point to, now | ||
| func routeKeys(route *routeapi.Route) ([]string, []int32) { |
There was a problem hiding this comment.
There's already a routeKey method in this file - could be confusing *Key vs *Keys but its minor.
There was a problem hiding this comment.
Ok, I've added another commit that renames and refactors this method. PTAL.
|
New code w/ |
|
@ramr Thank you for your diligence! @rajatchopra Would appreciate your eyes when you get a chance to make sure I have maintained your intent around a/b testing. |
|
Adding some logging cleanup. %v outputs garbage for a route. |
|
[test] flaked on #11016 (the router took longer than 1 minute to pull images and start them) |
|
flake #10773 re-merge? |
|
re-[test] |
1 similar comment
|
re-[test] |
marun
force-pushed
the
router-reload-only-when-changed
branch
from
faba567 to
de79651
Compare
|
Rebased |
Previously, 'Added' and 'Modified' route events would always result in a router state change that required a reload. This change ensures that the router computes the configuration of the route provided by an event and only makes a reload-requiring state change if the new configuration differs from the old.
Minor refactor and rename of the routeKeys (now getServiceUnits) utility function.
|
Evaluated for origin test up to de79651 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12532/) (Base Commit: 3c68360) |
|
[merge] |
|
Evaluated for origin merge up to de79651 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12562/) (Base Commit: 42ad22e) (Image: devenv-rhel7_5578) |
Previously, 'Added' and 'Modified' route events would always result in a router state change that required a reload. This change ensures that the router computes the configuration of the route provided by an event and only makes a reload-requiring state change if the new configuration differs from the old. Along with the changes from #12199, routers should no longer have to reload unless route and endpoint configuration changes.
Please review only c4636aa and 93173fe. The other commits are from #12199 and a necessary precursor to this work, but that PR may be close to merging and I didn't want to delay things by adding more code at the last minute.
cc: @openshift/networking @smarterclayton