add timeout http-keep-alive to the router template #13051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a customer reported that when using "timeout http-request" for slowloris protection it can impact connections with keep-alive. The HAProxy router sets "timeout http-keep-alive" to "timeout http-request" when the former is set and the latter is not and that can degrade the performance of browsers that do not expect such a low timeout for HTTP keep-alive connections. I added this timeout in commit: 527899e and it was removed in commit: a41ce2c. It looks like the removal was an oversight. Bug 1391585
|
@openshift/networking PTAL |
|
Where is ROUTER_SLOWLORIS_HTTP_KEEPALIVE documented? |
|
@pecameron added docs PR:3850 |
|
LGTM |
|
[merge] |
|
Evaluated for origin merge up to 7bfc0b9 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/908/) (Base Commit: 192e57e) (Image: devenv-rhel7_6048) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a customer reported that when using "timeout http-request" for slowloris
protection it can impact connections with keep-alive. The HAProxy router
sets "timeout http-keep-alive" to "timeout http-request" when the former
is set and the latter is not and that can degrade the performance of browsers
that do not expect such a low timeout for HTTP keep-alive connections.
I added this timeout in commit: 527899e and it was removed in
commit: a41ce2c. It looks like the removal was an oversight.
Bug 1391585