Add image-streams and update db-templates #17922

pvalena · 2017-12-22T12:52:30Z

for corresponding SCL containers.

I'll add image-streams for rhel7 and template updates in separate PRs.

source: https://github.com/sclorg/image-streams
CC: @hhorak

hhorak · 2017-12-22T21:28:27Z

@sspeiche @bparees FYI, any feedback welcome.

bparees · 2017-12-24T19:34:55Z

you'll need to run hack/update-generated-bindata.sh and include that updated file w/ your pr.

I assume all these new versions of images work w/ the existing sample apps they reference?

bparees · 2017-12-24T19:35:11Z

/ok-to-test

pvalena · 2018-01-02T09:46:58Z

@bparees, images are tested with in their respective container repos, including templates and sample apps.
f.e.: https://github.com/sclorg/mariadb-container/blob/master/test/run-openshift

If it looks ok to you, I'll update the PR later this week to include all changes in this PR (RHEL, bindata, templates).

bparees · 2018-01-02T14:40:13Z

@pvalena it looks fine to me, just tag me again when it's updated w/ the other content and i'll merge it.

sspeiche · 2018-01-03T18:32:23Z

@pvalena @hhorak looks fine to me, please update so we can get this in!

pvalena · 2018-01-05T00:59:33Z

@bparees, PTAL.

I've not added any new templates and I also did not update quickstarts (nginx image-streams were added).

pvalena · 2018-01-05T01:10:51Z

I've also cross-checked the changes for centos7 and rhel7 image-streams and they're the same.

bparees · 2018-01-05T04:07:09Z

examples/db-templates/mariadb-ephemeral-template.json

+      "template.openshift.io/long-description": "This template provides a standalone MariaDB server with a database created.  The database is not stored on persistent storage, so any restart of the service will result in all data being lost.  The database name, username, and password are chosen via parameters when provisioning this service.",
+      "template.openshift.io/provider-display-name": "Red Hat, Inc.",
+      "template.openshift.io/documentation-url": "https://github.com/sclorg/mariadb-container/blob/master/10.2/root/usr/share/container-scripts/mysql/README.md",
+      "template.openshift.io/support-url": "https://access.redhat.com"


what was the reasoning for adding the "template" prefix here? I don't believe it is correct:

https://github.com/openshift/origin/blob/master/pkg/api/constants.go

This had to be just copied from somewhere from origin/....
Sorry, we do not really know how those work. I'll fix it.
Thanks for checking!

openshift/origin#17922 (review)

Add new image-streams for centos7 and rhel7. - source: https://github.com/sclorg/image-streams Update db-templates/* to new version of corresponding container image. Add nginx to quickstarts/* and run `hack/update-external-examples.sh`. Update bindata. Add and fix tests. nginx -> docker.io/library/wordpress change: openshift#17922 (comment)

pvalena · 2018-01-11T19:56:09Z

Squashed.

pvalena · 2018-01-12T07:46:49Z

@bparees, what do those timeouts mean?
s: "timed out waiting for the condition",

bparees · 2018-01-12T15:28:01Z

@bparees, what do those timeouts mean?
s: "timed out waiting for the condition",

we're waiting for the mongodb image import to complete and it's never going to because the mongodb image isn't available on dockerhub yet.

pvalena · 2018-01-12T16:05:43Z

AFAICT the mongodb image available for some time now (I've tested it at 11:11 UTC+0).

bparees · 2018-01-12T16:12:54Z

/retest

bparees · 2018-01-12T17:14:16Z

@pvalena your latest failure:

test/cmd/newapp.sh:317: executing 'oc new-app --search --image-stream=nginx' expecting success and text 'Tags:\s+1.8, 1.10, 1.12, latest'
FAILURE after 0.437s: test/cmd/newapp.sh:317: executing 'oc new-app --search --image-stream=nginx' expecting success and text 'Tags:\s+1.8, 1.10, 1.12, latest': the output content test failed
Standard output from the command:
Image streams (oc new-app --image-stream=<image-stream> [--code=<source>])
-----
nginx
  Project: cmd-newapp
  Tags:    1.10, 1.12, 1.8, latest

looks like you just need to reorder the expected text.

Add new image-streams for centos7 and rhel7. - source: https://github.com/sclorg/image-streams Update db-templates/* to new version of corresponding container image. Add nginx to quickstarts/* and run `hack/update-external-examples.sh`. Update bindata. Add and fix tests. nginx -> docker.io/library/wordpress change: openshift#17922 (comment)

openshift/origin#17922 (review)

bparees · 2018-01-15T18:18:44Z

@pvalena

test/cmd/newapp.sh:321: executing 'oc new-app --search --image-stream=postgresql' expecting success and text 'Tags:\s+9.4, 9.5, latest'
FAILURE after 0.339s: test/cmd/newapp.sh:321: executing 'oc new-app --search --image-stream=postgresql' expecting success and text 'Tags:\s+9.4, 9.5, latest': the output content test failed
Standard output from the command:
Image streams (oc new-app --image-stream=<image-stream> [--code=<source>])
-----
postgresql
  Project: cmd-newapp
  Tags:    9.4, 9.5, 9.6, latest

Add new image-streams for centos7 and rhel7. - source: https://github.com/sclorg/image-streams Update db-templates/* to new version of corresponding container image. Add nginx to quickstarts/* and run `hack/update-external-examples.sh`. Update bindata. Add and fix tests. nginx -> docker.io/library/wordpress change: openshift#17922 (comment)

pvalena · 2018-01-16T12:28:34Z

@bparees, that seems to be all, apart from the timeouts.

* Replace 'template.openshift.io' with 'openshift.io' openshift/origin#17922 (review) * Remove ' (Persistent)' openshift/origin#17922 (review)

bparees · 2018-01-16T13:50:53Z

@pvalena since you changed the readiness probes, I suspect the timeouts are due to your changes. Have you tested those template changes elsewhere?

pvalena · 2018-01-16T14:17:58Z

Have you tested those template changes elsewhere?

@bparees , yes. All changes should be properly tested in their respective container-image repositories.
F.e. for postgresql in this PR, running this command,
which translates simply to oc process ... |create -f -.
Do you have more specifics on what failed?

bparees · 2018-01-16T15:08:55Z

I ran the tests locally w/ your commit and verified they pass.

/lgtm
/retest

openshift-ci-robot · 2018-01-16T15:09:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, pvalena

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~examples/db-templates/OWNERS~~ [bparees]
~~examples/image-streams/OWNERS~~ [bparees]
~~examples/quickstarts/OWNERS~~ [bparees]
~~pkg/oc/bootstrap/OWNERS~~ [bparees]
~~test/cmd/OWNERS~~ [bparees]
~~test/extended/OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Add new image-streams for centos7 and rhel7. - source: https://github.com/sclorg/image-streams Update db-templates/* to new version of corresponding container image. Add nginx to quickstarts/* and run `hack/update-external-examples.sh`. Update bindata. Add and fix tests. nginx -> docker.io/library/wordpress change: openshift#17922 (comment)

bparees · 2018-01-16T19:47:48Z

/retest

openshift-ci-robot · 2018-01-16T21:22:30Z

@pvalena: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_image_ecosystem	`9d12ad6`	link	`/test extended_image_ecosystem`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2018-01-16T23:36:08Z

Automatic merge from submit-queue (batch tested with PRs 17976, 17195, 18093, 18080, 17922).

pvalena · 2018-01-17T11:57:09Z

Thanks!

openshift/origin#17922 (review)

openshift-ci-robot requested review from csrwng and mfojtik December 22, 2017 12:52

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2017

bparees self-assigned this Dec 24, 2017

openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 24, 2017

pvalena force-pushed the image-streams branch from a2f9349 to 4a33bc6 Compare January 5, 2018 00:52

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2018

pvalena changed the title ~~Add new image-streams for centos7~~ Add image-streams and update db-templates Jan 5, 2018

bparees reviewed Jan 5, 2018

View reviewed changes

pvalena added a commit to pvalena/mariadb-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

6ad55d6

openshift/origin#17922 (review)

pvalena added a commit to pvalena/mongodb-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

9a1785b

openshift/origin#17922 (review)

pvalena added a commit to pvalena/mysql-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

711c17a

openshift/origin#17922 (review)

pvalena added a commit to pvalena/postgresql-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

96b9483

openshift/origin#17922 (review)

pvalena added a commit to pvalena/redis-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

b1614fc

openshift/origin#17922 (review)

pvalena added a commit to pvalena/s2i-perl-container that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

0b197ff

openshift/origin#17922 (review)

pvalena added a commit to sclorg/nginx-ex that referenced this pull request Jan 5, 2018

Replace 'template.openshift.io' with 'openshift.io'

6c90628

openshift/origin#17922 (review)

pvalena force-pushed the image-streams branch from 1de3eee to 9afab0a Compare January 15, 2018 13:03

pvalena added a commit to pvalena/mongodb-container that referenced this pull request Jan 15, 2018

Replace 'template.openshift.io' with 'openshift.io'

8244d6a

openshift/origin#17922 (review)

pvalena added a commit to pvalena/mongodb-container that referenced this pull request Jan 15, 2018

Remove ' (Persistent)'

31c60b5

openshift/origin#17922 (review)

pvalena force-pushed the image-streams branch from 9afab0a to 9d12ad6 Compare January 16, 2018 11:24

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2018

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2018

openshift-merge-robot merged commit b8f3833 into openshift:master Jan 16, 2018

pvalena deleted the image-streams branch January 17, 2018 11:55

kzon pushed a commit to kzon/taskor that referenced this pull request Apr 15, 2018

Remove ' (Persistent)'

88af9d6

openshift/origin#17922 (review)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add image-streams and update db-templates #17922

Add image-streams and update db-templates #17922

pvalena commented Dec 22, 2017

hhorak commented Dec 22, 2017 •

edited

Loading

bparees commented Dec 24, 2017

bparees commented Dec 24, 2017

pvalena commented Jan 2, 2018

bparees commented Jan 2, 2018

sspeiche commented Jan 3, 2018

pvalena commented Jan 5, 2018 •

edited

Loading

pvalena commented Jan 5, 2018

bparees Jan 5, 2018

pvalena Jan 5, 2018 •

edited

Loading

pvalena commented Jan 11, 2018

pvalena commented Jan 12, 2018

bparees commented Jan 12, 2018

pvalena commented Jan 12, 2018

bparees commented Jan 12, 2018

bparees commented Jan 12, 2018

bparees commented Jan 15, 2018

pvalena commented Jan 16, 2018

bparees commented Jan 16, 2018

pvalena commented Jan 16, 2018

bparees commented Jan 16, 2018

openshift-ci-robot commented Jan 16, 2018

bparees commented Jan 16, 2018

openshift-ci-robot commented Jan 16, 2018

openshift-merge-robot commented Jan 16, 2018

pvalena commented Jan 17, 2018

Add image-streams and update db-templates #17922

Add image-streams and update db-templates #17922

Conversation

pvalena commented Dec 22, 2017

hhorak commented Dec 22, 2017 • edited Loading

bparees commented Dec 24, 2017

bparees commented Dec 24, 2017

pvalena commented Jan 2, 2018

bparees commented Jan 2, 2018

sspeiche commented Jan 3, 2018

pvalena commented Jan 5, 2018 • edited Loading

pvalena commented Jan 5, 2018

bparees Jan 5, 2018

Choose a reason for hiding this comment

pvalena Jan 5, 2018 • edited Loading

Choose a reason for hiding this comment

pvalena commented Jan 11, 2018

pvalena commented Jan 12, 2018

bparees commented Jan 12, 2018

pvalena commented Jan 12, 2018

bparees commented Jan 12, 2018

bparees commented Jan 12, 2018

bparees commented Jan 15, 2018

pvalena commented Jan 16, 2018

bparees commented Jan 16, 2018

pvalena commented Jan 16, 2018

bparees commented Jan 16, 2018

openshift-ci-robot commented Jan 16, 2018

bparees commented Jan 16, 2018

openshift-ci-robot commented Jan 16, 2018

openshift-merge-robot commented Jan 16, 2018

pvalena commented Jan 17, 2018

hhorak commented Dec 22, 2017 •

edited

Loading

pvalena commented Jan 5, 2018 •

edited

Loading

pvalena Jan 5, 2018 •

edited

Loading