Pull HAProxy from the CentOS PaaS sig repo only #18073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
approved
|
Is this the right fix, or have we pushed haproxy18 to the wrong repo and should fix that instead? |
smarterclayton
force-pushed
the
pull_haproxy_from_centos
branch
from
55119a6 to
7d871e3
Compare
openshift-ci-robot
added
size/S
|
Testing with the paas7-common build tag. |
|
Revert my commit in this PR too, it looks like it's still pulling from the 38 testing repo in the CI job. |
|
I have https://github.com/openshift/origin/pull/18066/files which hopefully we will be able to merge and we'll just close this one. |
|
Please base your change on this - we shouldn't be mixing the repos in the
same file. Cherry-picking my commit is enough.
…On Thu, Jan 11, 2018 at 1:16 PM, Eric Paris ***@***.***> wrote:
I have https://github.com/openshift/origin/pull/18066/files which
hopefully we will be able to merge and we'll just close this one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18073 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pxcqQyPILtUoqOSjyh7s7A4EzIg4ks5tJk_igaJpZM4RbGEr>
.
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eparis