Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glog missing nodes #18606

Closed

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Feb 14, 2018

Depends on #18466
Addresses #18466 (comment)

cc @deads2k

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: deads2k

Assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 14, 2018
@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2018

Depends on #18466
Addresses #18466 (comment)

Changes are in last commit.

cc @deads2k

Seems like the last commit stands along. Try just that.

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Feb 15, 2018

Seems like the last commit stands along. Try just that.

Done

I think we should close this PR in favor of #18625, which brings in these changes

@juanvallejo juanvallejo force-pushed the jvallejo/glog-missing-nodes branch from c814872 to c7b68ac Compare February 15, 2018 23:05
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2018
@juanvallejo
Copy link
Contributor Author

/test gcp

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2018
@openshift-bot
Copy link
Contributor

@juanvallejo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanvallejo
Copy link
Contributor Author

Closing. This change was introduced in #18625

openshift-merge-robot added a commit that referenced this pull request Mar 20, 2018
Automatic merge from submit-queue (batch tested with PRs 18999, 18543).

adds dependency analysis

Depends on #18466
Depends on #18606

Adds dependency graph analysis.
Outputs "yours", "mine", "ours" dependencies.

Usage:
```bash
$ ./depcheck analyze --root=github.com/openshift/origin --entry=cmd/... --entry=pkg/... --entry=tools/... --entry=test/... --openshift --dep=github.com/openshift/origin/vendor/k8s.io/kubernetes
```

[Output of the command above](https://gist.github.com/juanvallejo/d83d2f56e4f7345c3f37769237cb12a1)

cc @deads2k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants