-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust jenkins template setting to account for effects of constrained… #18834
adjust jenkins template setting to account for effects of constrained… #18834
Conversation
Everything in DEFAULT_SKIP_LIST either (a) was already covered by test/exteded/util/test.go:excludedTests, or (b) no longer exists
"InSingleTenantContext()" included both the subnet and networkpolicy plugins. Rename the checks to "InIsolatingContext" (multitenant) and "InNonIsolatingContext" (subnet/networkpolicy).
Rather than requiring environment variables to be set, figure out from the plugin name whether to test isolation/networkpolicy.
Introduced dns-proxy egress router that allows specifying DNS name for EGRESS_DESTINATION. Currently, dns-proxy egress mode implementation is based on HAProxy. HAProxy 1.6+ version is used to leverage DNS resolution at runtime.
When router stats are on, use the service serving cert always
Add a new scrape target for the router. The router requires a token with permission to see routers/metrics in route.openshift.io, so create a new service account specifically for scraping and add the appropriate roles. Also create an out of the box prometheus-reader service account which has view access on the current project.
Signed-off-by: Gladkov Alexey <[email protected]>
Will simplify future refactors
Newer docker clients create the canonical form of this reference which can result in being unable to access the image directly. Use our own namespace instead.
Had been accidentally merged when files were moved
…annot_delete_builds_in_namespace Automatic merge from submit-queue (batch tested with PRs 18781, 18769). Fixes: cannot prune builds on buildConfig change
…s-pipeline-test Automatic merge from submit-queue (batch tested with PRs 18781, 18769). add ext test for pipeline bc deletion behavior @openshift/sig-developer-experience ptal new test to validate recent bug fix in sync plugin
This should be the last piece I need to actually approve CLI changes.
Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801). Run cluster-up using separate processes Builds on openshift#18536 . It removes the old options. Possible fallout here: 1. logging ? - webconsole wiring perhaps? 2. metrics ? - webconsole wiring perhaps? 3. running from old config? - our config structure looks entirely different. /assign @mfojtik /assign @soltysh
Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801). audit doesn't respect embedded config The audit config loading doesn't respect embedded config. /assign @soltysh
Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801). change how extended network tests are selected/skipped Currently the extended networking test requires you to set `NETWORKING_E2E_ISOLATION=true` when using the multitenant plugin, and `NETWORKING_E2E_NETWORKPOLICY=true` when using the networkpolicy plugin (or a third-party plugin). This changes it to just check the active network plugin at runtime, and select the right tests automatically based on that. Which means 1. When running the tests against an installed cluster with `OPENSHIFT_TEST_KUBECONFIG=... ./test/extended/networking.sh`, you don't have to also set the correct additional environment variables. 2. We can change conformance_gce to install multitenant rather than subnet, and the tests will adapt themselves correctly automatically. I know at some point someone said we were supposed to decide what tests to do based on labels or whatever, but the checking-at-runtime approach seems to be more inline with, eg, `framework.SkipUnlessNodeCountIsAtLeast()`, `framework.SkipUnlessLocalEphemeralStorageEnabled()`, `framework.SkipUnlessNodeOSDistroIs()`, etc.
Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801). UPSTREAM: 60289: fix freespace for image GC kubernetes/kubernetes#60289
Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801). Fix handleDeleteSubnet() to release network from subnet allocator
Automatic merge from submit-queue. Preserve router metrics across restarts Router metrics aren't preserved across HAProxy reloads. To counter that, capture the state of certain counter style metrics (NOT rate style metrics) immediately before a router reload, then add them to subsequent reports. Some metrics will be lost (any recorded between the capture and the actual restart time) but this will make metrics accurate to within a few percent, even when routers are restarting frequently. This increases the cost of the reload slightly, but metrics are arguably worth it.
Add enj to completions OWNERS
UPSTREAM: 59365: Fix StatefulSet set-based selector bug
There is also a lot of history and diagnostic details in openshift/jenkins#440 |
9304ece
to
10d5436
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gabemontero Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ah ... something happened while trying ot update closing this PR out, will redo 3.9 |
@gabemontero: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
… default max heap
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551500
Fixes openshift/jenkins#501
@openshift/sig-developer-experience @sdodson ptal / fyi