Drop template wrapping from bootstrap policy file #19847
Conversation
openshift-ci-robot
added
the
size/S
|
/retest |
It is impossible for any docs to exist. You recently made the bootstrap file have a format that auth reconcile would even look at (RBAC) |
| } | ||
| } | ||
|
|
||
| versionedPolicyTemplate, err := legacyscheme.Scheme.ConvertToVersion(policyTemplate, latest.Version) | ||
| versionedPolicyList, err := legacyscheme.Scheme.ConvertToVersion(policyList, latest.Version) |
There was a problem hiding this comment.
Confirm that this is still needed.
There was a problem hiding this comment.
Yep, without this the file has no List
|
@openshift/sig-security @openshift/cli-review any concerns about changing this to just a list of items instead a template? No template features were used and we just changed the entire encoding of the file in #19756. It allows us to drop a pointless |
|
I have no objections dropping template, it doesn't seem useful for bootstrap roles anyway |
|
👍 for the change |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
fixes #19819
This will also need doc updates wherever
oc processis invoked to pass a bootstrap file tooc auth reconcile