fix the go 1.10 unit test failures

[deads2k]

@smarterclayton the unit weren't flakes. They were failing one these directives https://unsid.com/openshift/pull-ci-origin-unit/690/ which set non-zero return values.

[smarterclayton]

/lgtm

[deads2k]

contained unit test fix. plan to merge on green to unstick CI.

[deads2k]

/hold

updating for vet

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[deads2k]

/hold cancel

[deads2k]

@smarterclayton updated

[smarterclayton]

Now it's gofmt

./pkg/oauthserver/osinserver/osinserver_test.go
./pkg/security/securitycontextconstraints/provider_test.go
./test/integration/oauth_cert_fallback_test.go
./test/integration/oauthstorage_test.go

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cmd/OWNERS [deads2k,smarterclayton]
• pkg/oauthserver/OWNERS [deads2k,smarterclayton]
• pkg/oc/OWNERS [deads2k,smarterclayton]
• pkg/security/OWNERS [deads2k,smarterclayton]
• test/integration/OWNERS [deads2k,smarterclayton]
• tools/rebasehelpers/OWNERS [deads2k,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

green unit, green verify

[enj]

/retest

[deads2k]

it got past the ones it affects. merging to unblock queue.

[openshift-ci-robot]

@deads2k: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/gcp	eee71bb	link	/test gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.