-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO-1419: OCL E2E Testing #29276
base: main
Are you sure you want to change the base?
MCO-1419: OCL E2E Testing #29276
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RishabhSaini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RishabhSaini: This pull request references MCO-1419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ebba0b2
to
715342a
Compare
f6edcc4
to
61b2095
Compare
/refresh |
db22dc7
to
c7399d5
Compare
@RishabhSaini: This pull request references MCO-1419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@RishabhSaini: This pull request references MCO-1419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
machineconfigpool: test pool for layering machineosconfig: test mosc that opts the MCP into layering Opts in a pool into OCL and triggers a build. Ensures that the build completes and is successfully rolled out to all the nodes in the pool. This required to use some of the existing function in the Machine Config Operator repo and hence its latest 2024 version was imported. Which updates github.com/docker/docker from v20.10.27 -> v24.0.7 Which breaks github.com/fsouza/go-dockerclient v1.7.1 since it relies on docker v20.10.27 Hence, I manually update both docker and go-dockerclient to their latest version
Hello! In which platforms will the test be executed? In the test we are using the internal registry to store the osImage. It means that the test may fail in the following installations:
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Job Failure Risk Analysis for sha: 08667cb
Showing 20 of 22 jobs analysis |
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ocl test:
Tests whether one can turn on and opt in a pool for OCL. This involves verifying if the custom image specified in the mosc is built and successfully rolled out the specified nodes within 20 mins
go.mod changes:
adds github.com/machine-config-operator 2024 version
which updates github.com/docker/docker from v20.10.27 -> v24.0.7
which breaks github.com/fsouza/go-dockerclient v1.7.1 since it relies on docker v20.10.27
Hence, I manually update both github.com/docker/docker to v27.3.1 and github.com/fsouza/go-dockerclient to v1.12.0 which is their latest version
This keeps go dependencies happy :)