Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple attempts in egress firewall test #29615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldoktor
Copy link

@ldoktor ldoktor commented Mar 21, 2025

this test is failing when using kata-containers, which might be related to longer startup times of kata-containers:

curl: (28) Connection timed out after 1001 milliseconds

let's use the "--retry" feature of curl. This should not affect the successful tests as they should return immediately, while it might prolong the failing tests from 3s to 30s. With kata we need about 6-12s so 30s should be safe for us.

this test is failing when using kata-containers, which might be related
to longer startup times of kata-containers:

    curl: (28) Connection timed out after 1001 milliseconds

let's use the "--retry" feature of curl. This should not affect the
successful tests as they should return immediately, while it might
prolong the failing tests from 3s to 30s. With kata we need about 6-12s
so 30s should be safe for us.

Signed-off-by: Lukáš Doktor <[email protected]>
@openshift-ci openshift-ci bot requested review from knobunc and trozet March 21, 2025 08:00
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ldoktor
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

@ldoktor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive ce97626 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview ce97626 link false /test e2e-metal-ipi-ovn-dualstack-bgp-techpreview
ci/prow/e2e-openstack-ovn ce97626 link false /test e2e-openstack-ovn
ci/prow/e2e-openstack-serial ce97626 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-upgrade ce97626 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-microshift ce97626 link true /test e2e-aws-ovn-microshift
ci/prow/okd-scos-e2e-aws-ovn ce97626 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-fips-serial ce97626 link false /test e2e-gcp-fips-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 ce97626 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade ce97626 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling ce97626 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling ce97626 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling ce97626 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-hypershift-conformance ce97626 link false /test e2e-hypershift-conformance
ci/prow/okd-e2e-gcp ce97626 link false /test okd-e2e-gcp
ci/prow/e2e-gcp-disruptive ce97626 link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-ovn-etcd-scaling ce97626 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback ce97626 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-serial ce97626 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ldoktor
Copy link
Author

ldoktor commented Mar 26, 2025

@knobunc @trozet hello folks, this is my first contribution in openshift/origin, should I keep rebasing this PR or should I wait for a review first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants