Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-5217: Add EgressIP route advertisement test #29617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Mar 21, 2025

  1. Tests for both IPv4 and IPv6 EgressIP
  2. Tests for advertising EgressIP for the default network and UDN
    to the default VRF.

based on #29419

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Mar 21, 2025
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pliurh
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-trt bot commented Mar 21, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: c2bc2ff

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-techpreview Medium - "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising the default network [apigroup:user.openshift.io][apigroup:security.openshift.io] External host should be able to query route advertised pods by the pod IP [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-techpreview Medium - "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising the default network [apigroup:user.openshift.io][apigroup:security.openshift.io] pods should communicate with external host without being SNATed [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.

New tests seen in this PR at sha: c2bc2ff

  • "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising the default network [apigroup:user.openshift.io][apigroup:security.openshift.io] External host should be able to query route advertised pods by the pod IP [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising the default network [apigroup:user.openshift.io][apigroup:security.openshift.io] pods should communicate with external host without being SNATed [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

pliurh added 2 commits April 3, 2025 01:25
tests for advertising the default network
tests for advertising a cluster user definined network

Signed-off-by: Peng Liu <[email protected]>
1. Tests for both IPv4 and IPv6 EgressIP
2. Tests for advertising EgressIP for the default network and UDN
   to the default VRF.
@pliurh pliurh changed the title WIP: Bgp eip SDN-5217: Add EgressIP route advertisement test Apr 3, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2025
@openshift-ci-robot
Copy link

@pliurh: This pull request references SDN-5217 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  1. Tests for both IPv4 and IPv6 EgressIP
  2. Tests for advertising EgressIP for the default network and UDN
    to the default VRF.

based on #29419

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling 448c951 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview 448c951 link false /test e2e-metal-ipi-ovn-dualstack-bgp-techpreview
ci/prow/e2e-azure-ovn-etcd-scaling 448c951 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-etcd-scaling 448c951 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-ipv6 448c951 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 448c951 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-azure-ovn-upgrade 448c951 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-disruptive 448c951 link false /test e2e-gcp-disruptive
ci/prow/okd-e2e-gcp 448c951 link false /test okd-e2e-gcp
ci/prow/e2e-metal-ipi-ovn-dualstack 448c951 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 448c951 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 448c951 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 448c951 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-ovn 448c951 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 448c951 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-metal-ipi-serial 448c951 link false /test e2e-metal-ipi-serial
ci/prow/e2e-aws-ovn-single-node 448c951 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-serial 448c951 link false /test e2e-openstack-serial
ci/prow/e2e-aws-disruptive 448c951 link false /test e2e-aws-disruptive
ci/prow/e2e-agnostic-ovn-cmd 448c951 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn 448c951 link false /test e2e-metal-ipi-ovn
ci/prow/okd-scos-e2e-aws-ovn 448c951 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 448c951 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-vsphere-ovn-etcd-scaling 448c951 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial 448c951 link false /test e2e-gcp-fips-serial
ci/prow/e2e-metal-ipi-virtualmedia 448c951 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-ovn-single-node-upgrade 448c951 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-trt bot commented Apr 3, 2025

Job Failure Risk Analysis for sha: 448c951

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
---
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
Potential external regression detected for High Risk Test analysis
---
[bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available
Potential external regression detected for High Risk Test analysis
---
Showing 4 of 5 test results
pull-ci-openshift-origin-main-e2e-gcp-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants