NO-JIRA: Env override NETWORKING_E2E_BOND_MTU #29630
Conversation
This commit introduces NETWORKING_E2E_BOND_MTU variable. The test for creating "bond" interface can read it to override the default value. The default value is used when .status.clusterNetworkMTU is undefined on the Network source "cluster" and it is automatically set by kernel. The .status.clusterNetworkMTU might not be defined when using acustom CNI plugin such as Cilium.
openshift-ci-robot
added
the
jira/valid-reference
|
@mgencur: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-1.20 |
|
@mgencur: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…platform This commit brings a workflow for running conformance tests on hosted cluster created by kubevirt. The manamenent cluster is bare metal. * Introduce step hypershift-kubevirt-health-check-nodecount for cases when HostedCluster doesn't get Complete until Cilium CNI (or other network stack) is installed on Nodes. In this case, we only check that number of available nodes matches the one from HostedCluster resource. * Exclude same tests as for hypershift-aws-conformance-cilium workflow as they fail for Cilium in general (not specific for kubevirt) * Exclude "StatefulSet Basic" and "StatefulSet Non-retain". Copied from hypershift-kubevirt-baremetalds-conformance workflow.These tests are flaky on Kubevirt. * Exclude "[Feature:bond]" until openshift/origin#29630 is merged.
…platform This commit brings a workflow for running conformance tests on hosted cluster created by kubevirt. The manamenent cluster is bare metal. * Introduce step hypershift-kubevirt-health-check-nodecount for cases when HostedCluster doesn't get Complete until Cilium CNI (or other network stack) is installed on Nodes. In this case, we only check that number of available nodes matches the one from HostedCluster resource. * Exclude same tests as for hypershift-aws-conformance-cilium workflow as they fail for Cilium in general (not specific for kubevirt) * Exclude "StatefulSet Basic" and "StatefulSet Non-retain". Copied from hypershift-kubevirt-baremetalds-conformance workflow.These tests are flaky on Kubevirt. * Exclude "[Feature:bond]" until openshift/origin#29630 is merged.
|
/retest |
…platform This commit brings a workflow for running conformance tests on hosted cluster created by kubevirt. The manamenent cluster is bare metal. * Introduce step hypershift-kubevirt-health-check-nodecount for cases when HostedCluster doesn't get Complete until Cilium CNI (or other network stack) is installed on Nodes. In this case, we only check that number of available nodes matches the one from HostedCluster resource. * Exclude same tests as for hypershift-aws-conformance-cilium workflow as they fail for Cilium in general (not specific for kubevirt) * Exclude "StatefulSet Basic" and "StatefulSet Non-retain". Copied from hypershift-kubevirt-baremetalds-conformance workflow.These tests are flaky on Kubevirt. * Exclude "[Feature:bond]" until openshift/origin#29630 is merged.
…platform This commit brings a workflow for running conformance tests on hosted cluster created by kubevirt. The manamenent cluster is bare metal. * Introduce step hypershift-kubevirt-health-check-nodecount for cases when HostedCluster doesn't get Complete until Cilium CNI (or other network stack) is installed on Nodes. In this case, we only check that number of available nodes matches the one from HostedCluster resource. * Exclude same tests as for hypershift-aws-conformance-cilium workflow as they fail for Cilium in general (not specific for kubevirt) * Exclude "StatefulSet Basic" and "StatefulSet Non-retain". Copied from hypershift-kubevirt-baremetalds-conformance workflow.These tests are flaky on Kubevirt. * Exclude "[Feature:bond]" until openshift/origin#29630 is merged.
|
@mgencur: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 8ee656a
|
This commit introduces NETWORKING_E2E_BOND_MTU variable. The test for creating "bond" interface can read it to override the default value. The default value is used when .status.clusterNetworkMTU is undefined on the Network "cluster". It is automatically set by kernel in that case. The .status.clusterNetworkMTU might not be defined when using a custom CNI plugin such as Cilium.
We have run into test failures when testing Hypershift/HostedControlPlane. When the management cluster has a specific clusterNetworkMTU and the "hosted" cluster uses Cilium CNI then the hosted cluster might use a bigger value for MTU than the management cluster. In this case, the following test error happens:
Can be seen in this run
This PR allows overriding the default value 1500 from the error above with a value matching the slave MTU.