[Bugzilla 1261860] fix adding labels to build-pod

[php-coder]

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1261860

I've fixed adding labels to build-pod. @rhcarvalho PTAL.

One doubt that I have is we should add all labels? Because after this fix I see the following

[vagrant@openshiftdev sample-app]$ oc new-app application-template-stibuild.json -l bug=1261860 
...
[vagrant@openshiftdev sample-app]$ oc describe pod ruby-sample-build-1-build | grep Labels
Labels:             bug=1261860,buildconfig=ruby-sample-build,name=ruby-sample-build,openshift.io/build.name=ruby-sample-build-1,template=application-template-stibuild

As we can see there is one mine label, one standard and 3 additional. I'm not sure about these extra labels. Do we need them?

[bparees]

i'd be surprised if we don't already have this function somewhere else.

[bparees]

yes i think copying all the labels from the build into the build pod is ok, it ties them together in a useful way.

[liggitt]

Wait, didn't we decide to stop adding all labels to the build pod a while ago? Why are we readding them now

[liggitt]

See #3502, #3508

[bparees]

hm. @liggitt is correct. we should just close the associated bug as won't fix.

[php-coder]

we should just close the associated bug as won't fix.

done