Inital start to be able to redirect from http to https. #8258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-bot
added
needs-rebase
openshift-bot
added
needs-rebase
openshift-bot
added
needs-rebase
openshift-bot
removed
the
needs-rebase
|
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
openshift-bot
added
the
needs-rebase
| // InsecureTerminationPolicy indicates the desired behavior for | ||
| // insecure connections to one of the tls (edge,passthrough,reencrypt) route: | ||
| // disable, allow or redirect | ||
| InsecureTerminationPolicy InsecureTerminationPolicyType |
There was a problem hiding this comment.
Why would we not just add "Redirect" to "InsecureEdgeTerminationPolicy"? I don't see the value in adding the new external field - we can just rename it in a future version. Broadening EdgeTerminationPolicy to apply to all termination types doesn't seem to have a disadvantage I can see. Examples?
There was a problem hiding this comment.
#11953 is open to do just that.
|
@cw-aleks: Sorry, I missed this until today. I am closing in preference to #11953 Please tell me if that PR does not accommodate your needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #5946
#5946