Bugfix #1343358: Enforce --tty=false flag for "oc debug" #9637
Conversation
|
Please update the PR title to be more descriptive than just a bug number - thanks! |
|
Why do you have a merge commit? |
damemi
changed the title
|
Sorry, the merge commit was my mistake. Should be set now |
|
@damemi Add a link to the bug in the PR description, with the syntax: "Fixes LINK". This will make the robot add a comment to the bug when this gets merged. Also the commit message must be more descriptive about what it's doing, it doesn't have to necessarily mention the bug number. "Enforce --tty=false flag for 'oc debug'" looks like a good commit message, for example. |
|
@damemi I'd also suggest adding a test in |
damemi
force-pushed
the
tty-bug
branch
2 times, most recently
from
3a50424 to
723d30d
Compare
Changes behavior for "oc debug" command, specifically with "--tty" flag. Prior behavior left "--tty" essentially useless, as it was not checked if the user specifically requested to disable TTY by passing "--tty=false" (if the command was run in a terminal, and "--no-tty" was not set to "true", it would always default to a TTY, even with "--tty=false" set. This change allows both flags to remain for compliance with any other programs that might use them, at least until one is deprecated as it has been suggested that having both is redundant. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1343358
|
@fabianofranz Bump |
|
[test] |
|
Evaluated for origin test up to 313a029 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6906/) |
|
[merge] |
|
Evaluated for origin merge up to 313a029 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6937/) |
|
@damemi Remember to put the bug ON_QA with a comment and link to this PR. Tks! |
Changes behavior for "oc debug" command, specifically with
--ttyflag. Prior behavior left--ttyessentially useless, as it was not checked if the user specifically requested to disable TTY by passing--tty=false(if the command was run in a terminal, and--no-ttywas not set totrue, it would always default to a TTY, even with--tty=falseset.This change allows both flags to remain for compliance with any other programs that might use them, at least until one is deprecated as it has been suggested that having both is redundant.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1343358