test/e2e: Preserve the existing environment when using exec.Command

[timflannagan]

Ensure we're preserving the existing environment before running any exec.Commands. I noticed locally when running the e2e suite that the underlying bash script wasn't able to find 'oc' despite that executable being in my $PATH, and the which oc was outputting strange results when run in isolation. Explicitly specifying the existing environment via os.Environ() which should include the $PATH variable helped fix this pathing issue.

Signed-off-by: timflannagan [email protected]

[timflannagan]

Waiting for CI feedback just in case.

/hold

[openshift-ci]

@timflannagan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-techpreview-operator	851dc05	link	false	/test e2e-aws-techpreview-operator
ci/prow/e2e-aws-techpreview	851dc05	link	false	/test e2e-aws-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[timflannagan]

alright cool, looks like these changes still work in CI.

/hold cancel

[tylerslaton]

@timflannagan Do we not care about the two failures that we're seeing for CI here? Changes look good but want to check first.

[timflannagan]

Nope I think it's fine to merge this.

[tylerslaton]

Cool, in that case this looks good.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timflannagan]

These changes only affect the internal testing suite. Adding the required labels.

/label qe-approved
/label docs-approved
/label px-approved

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-platform-operators-manager-container-v4.12.0-202305022015.p0.gd40fae8.assembly.stream for distgit ose-cluster-platform-operators-manager.
All builds following this will include this PR.