Skip to content

Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 104 commits into from
Dec 9, 2020

Conversation

dgrisonnet
Copy link
Member

Update prometheus-operator downstream fork to the latest upstream release for the OpenShift 4.7 feature freeze checklist.

Amab and others added 30 commits October 8, 2020 22:41
I think this dependency is usually not needed any longer, given that
the standard library has the likes of errors.New, and fmt.Errorf.

My understanding is that apis/monitoring is a standalong module now to
make it easier for other projects to import it, with a minimal set of
transitive dependecies to worry about. If I'm correct, then
github.com/pkg/errors is an easy one to keep out.
…ext-todo

Refactor to remove context.TODO
Remove pkg/errors dep from apis/monitoring module
`admissionReviewVersions` and `sideEffects` fields are now required for `admissionregistration.k8s.io/v1`
Add WeChat Receiver type to AlertmanagerConfig CRD
prometheus: Implement sharding mechanism
Signed-off-by: sheetalsingala <[email protected]>
@lilic
Copy link

lilic commented Dec 7, 2020

For this we need the PR in CMO first, as there we create the CRDs.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@simonpasquier
Copy link

simonpasquier commented Dec 9, 2020

/title Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0

@simonpasquier
Copy link

simonpasquier commented Dec 9, 2020

/retitle Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0

@openshift-ci-robot openshift-ci-robot changed the title MON-1302: Bump prometheus-operator to v0.44.0 Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0 Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Dec 9, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2020

@dgrisonnet: This pull request references Bugzilla bug 1893798, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 9, 2020
@dgrisonnet
Copy link
Member Author

Unholding as the bump in CMO was merged: openshift/cluster-monitoring-operator#1013

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@dgrisonnet
Copy link
Member Author

/retest

@simonpasquier
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@dgrisonnet
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 688a33e into openshift:master Dec 9, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2020

@dgrisonnet: All pull requests linked via external trackers have merged:

Bugzilla bug 1893798 has been moved to the MODIFIED state.

In response to this:

Bug 1893798: MON-1302: Bump prometheus-operator to v0.44.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet deleted the bump-v0.44.0 branch December 9, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.