-
Notifications
You must be signed in to change notification settings - Fork 53
podvm: disable cloud-init unsafe modules for CoCo #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snir911 what's the tmporary change
commit for ?
tmporary change was to test wheter this is works with libvirt provider, currently thanks to @ajayvic it seems to be failing so i removed this patch for now
|
this is executed when CONFIDENTIAL_COMPUTE_ENABLED=yes or based on the CUSTOM_CLOUD_INIT_MODULES value, if set in either case, this is currently disabled for the libvirt provider Signed-off-by: Snir Sheriber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@snir911: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the assumption that the content of 99_coco_only_allow.cfg
is correct, the patch looks good to me.
Thanks @snir911 !
this is executed when CONFIDENTIAL_COMPUTE_ENABLED=yes or based on the EXPLICIT_adapt_cloud_init value, if set
in either case, this is currently disabled for the libvirt provider
Fixes: KATA-3269