Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core dependencies (CVE fixes) #1173

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Update core dependencies (CVE fixes) #1173

merged 1 commit into from
Oct 1, 2024

Conversation

sayan-biswas
Copy link
Contributor

@sayan-biswas sayan-biswas commented Sep 28, 2024 •
edited
Loading

Changes:

  • Update docker dependency
  • Adjust code for deprecated docker APIs

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
@sayan-biswas sayan-biswas force-pushed the fix-cve branch 5 times, most recently from 343d601 to 92da20c Compare September 29, 2024 10:53
adambkaplan
adambkaplan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dependency updates and code changes look good!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@adambkaplan
Copy link
Contributor

/approve

Changing this to an approve - we should bring in the ubi8 change and the dependency updates

/lgtm cancel

Looks like the switch to go 1.21 is not done right/breaking CI.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@sayan-biswas
Copy link
Contributor Author

/retest

@sayan-biswas sayan-biswas force-pushed the fix-cve branch 3 times, most recently from e57c842 to 809661c Compare September 30, 2024 20:58
@sayan-biswas
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
@sayan-biswas
Update core dependencies (CVE fixes)
2296725 
Changes:
- Update docker dependency
- Adjust code for deprecated docker APIs
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@sayan-biswas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2296725 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sayan-biswas
Copy link
Contributor Author

/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / source-to-image-enterprise-contract / source-to-image

In response to this:

/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sayan-biswas
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
ramessesii2
ramessesii2 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@ramessesii2 ramessesii2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramessesii2, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 739b5e3 into openshift:master Oct 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@ramessesii2 ramessesii2 ramessesii2 approved these changes

@apoorvajagtap apoorvajagtap Awaiting requested review from apoorvajagtap

@jkhelil jkhelil Awaiting requested review from jkhelil

Assignees

@adambkaplan adambkaplan

@ramessesii2 ramessesii2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayan-biswas @adambkaplan @ramessesii2