Fix coverity issues: batch 2 #30088
Merged
Fix coverity issues: batch 2 #30088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: transformations
itikhono
commented
Apr 11, 2025
| return std::numeric_limits<dst_type>::max(); | ||
| } else if (val < std::numeric_limits<dst_type>::lowest()) { | ||
| return std::numeric_limits<dst_type>::lowest(); | ||
| if (std::numeric_limits<src_type>::max() > std::numeric_limits<dst_type>::max()) { |
There was a problem hiding this comment.
probably it should be constexpr to resolve the coverity issue
but our bfloat16 impl doesn't have constexpr > and < operators overloaded
There was a problem hiding this comment.
this is not performance critical, the code logic works correctly.
decided to move it to the separate PR
…tps://github.com/itikhono/openvino into itikhono/coverity_issues/control_flow_and_others
evkotov
approved these changes
Apr 15, 2025
CuriousPanCake
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Control flow / Program hangs issues
Tickets: