Workaround for podman s2i builds #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/S
|
@tumido worked on my machine with Docker. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: durandom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
|
the image build works using podman 👍 |
cfchase
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Apply podman workarounds if it's selected as the
CONTAINER_BUILDERor if it emulatesdocker.S2I is unable to fix this for over year and half... openshift/source-to-image#966 They have a workaround available though, a
---as-dockerfileoption. This makess2icreate aDockerfileinstead of building the image directly. ThisDockerfilecan be later used to build the target viapodman/buildah.@cfchase please verify it still builds with docker
@goern can you please try out against the fedora's podman if this builds using the podman workarounds