fix: Scorecard configuration ServiceAccount tag (#166)

sergioifg94 · web-flow · commit 3e95d2c8cdd8 · 2021-11-03T16:40:46.000+01:00
The tag that configures the serialization of the ServiceAccount field
for the Scorecard configuration incorrectly names the field
"string", which results in the `serviceaccount` field being empty after
unmarshalling, therefore being ignored.
Update the tag to name the field `serviceaccount`
diff --git a/pkg/apis/scorecard/v1alpha3/configuration_types.go b/pkg/apis/scorecard/v1alpha3/configuration_types.go
@@ -24,7 +24,7 @@ type Configuration struct {
 	Storage Storage `json:"storage,omitempty" yaml:"storage,omitempty"`
 
 	// ServiceAccount is the service account under which scorecard tests are run. This field is optional. If left unset, the `default` service account will be used.
-	ServiceAccount string `json:"string,omitempty" yaml:"string,omitempty"`
+	ServiceAccount string `json:"serviceaccount,omitempty" yaml:"serviceaccount,omitempty"`
 }
 
 // StageConfiguration configures a set of tests to be run.

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ type Configuration struct {`
`24`	`24`	Storage Storage `json:"storage,omitempty" yaml:"storage,omitempty"`
`25`	`25`
`26`	`26`	// ServiceAccount is the service account under which scorecard tests are run. This field is optional. If left unset, the `default` service account will be used.
`27`		- ServiceAccount string `json:"string,omitempty" yaml:"string,omitempty"`
	`27`	+ ServiceAccount string `json:"serviceaccount,omitempty" yaml:"serviceaccount,omitempty"`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`// StageConfiguration configures a set of tests to be run.`