Fix Scorecard configuration ServiceAccount tag #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag that configures the serialization of the ServiceAccount field for the Scorecard configuration incorrectly names the field "string", which results in the `serviceaccount` field being empty after unmarshalling, therefore being ignored. Update the tag to name the field `serviceaccount`
jmccormick2001
approved these changes
Oct 27, 2021
|
Thanks for approving this PR @jmccormick2001. Can someone please add /lgtm to merge it? |
|
Hi @awgreene @gallettilance @theishshah could you review this PR, please? |
gallettilance
approved these changes
Nov 3, 2021
|
/lgtm |
dinhxuanvu
approved these changes
Nov 3, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, sergioifg94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag that configures the serialization of the
ServiceAccountfield for the Scorecard configuration incorrectly names the field "string", which results in theserviceaccountfield being empty after unmarshalling, therefore being ignored.Update the tag to name the field
serviceaccount