Skip to content

modified the controller-runtime and controller-tools versions #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2021
Merged

modified the controller-runtime and controller-tools versions #154

merged 3 commits into from
Sep 8, 2021

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Sep 7, 2021 •
edited
Loading

Bumping controller-runtime and controller-tools version.

@varshaprasad96
Copy link
Member

@laxmikantbpandhare can you change the commit message to bumping controller-runtime and controller-tools version specifically, k8s has already been updated to 1.22. Also, can you run go mod tidy and make vendor.

@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare can you change the commit message to bumping controller-runtime and controller-tools version specifically, k8s has already been updated to 1.22. Also, can you run go mod tidy and make vendor.

@varshaprasad96 I updated the commit message and also ran make vendor

@varshaprasad96
Copy link
Member

/lgtm

jmrodri
jmrodri approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
rashmigottipati
rashmigottipati approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri
Copy link
Member

jmrodri commented Sep 8, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, laxmikantbpandhare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit a80624e into operator-framework:master Sep 8, 2021
awgreene added a commit to awgreene/api that referenced this pull request Dec 8, 2021
@awgreene
Revert "modified the controller-runtime and controller-tools versions (…
433f1b6 
…operator-framework#154)"

This reverts commit a80624e.
@awgreene awgreene mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@ecordell ecordell Awaiting requested review from ecordell

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@jmrodri jmrodri

@rashmigottipati rashmigottipati

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laxmikantbpandhare @varshaprasad96 @jmrodri @rashmigottipati @openshift-merge-robot