Add sort.Sort support to operatorsv1.Components #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Part of the work required to fix operator-framework/operator-lifecycle-manager#2874 |
This commit updates the operatorsv1.Components structure to implement the interface required by the sort.Sort function provided in golang. Signed-off-by: Alexander Greene <[email protected]>
awgreene
force-pushed
the
sort-component-references
branch
from
891ec1a to
0389ef7
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
joelanford
reviewed
Oct 27, 2022
| // Less returns true if argument i should appear in an ordered list | ||
| // of references before argument j. | ||
| // Used to implement the sort.Sort interface. | ||
| func (c Components) Less(i, j int) bool { |
There was a problem hiding this comment.
Do we need to define the functions to satisfy sort.Sort in the API? Or can we just call sort.Slice at the sort call site with this less function?
There was a problem hiding this comment.
Yep, moved it in that direction!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the operatorsv1.Components structure to implement the interface required by the sort.Sort function provided in golang.
Signed-off-by: Alexander Greene [email protected]