New condition types #282
Merged
New condition types #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2023 15:00
It was previously defined and used in the operator codebase. Signed-off-by: Mikalai Radchuk <[email protected]>
These conditions will be used to indicate unpack status on the subscription level. Previously unpack status was indicated on the InstallPlan, but since we now want to prevent InstallPlan from being created in a case of unpack job failure we need to indicate unpack job failures in Subscription conditions.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
commented
Apr 12, 2023
| @@ -239,6 +239,9 @@ const ( | |||
| // BundleLookupPending describes BundleLookups that are not complete. | |||
| BundleLookupPending BundleLookupConditionType = "BundleLookupPending" | |||
|
|
|||
| // BundleLookupFailed describes conditions types for when BundleLookups fail | |||
| BundleLookupFailed BundleLookupConditionType = "BundleLookupFailed" | |||
There was a problem hiding this comment.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tmshort
reviewed
Apr 12, 2023
| SubscriptionBundleUnpacking SubscriptionConditionType = "BundleUnpacking" | ||
|
|
||
| // SubscriptionBundleUnpackFailed indicates that the unpack job failed | ||
| SubscriptionBundleUnpackFailed SubscriptionConditionType = "BundleUnpackFailed" |
There was a problem hiding this comment.
@tmshort will be used in operator-framework/operator-lifecycle-manager#2942
11 tasks
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1kola, perdasilva, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for operator-framework/operator-lifecycle-manager#2942