-
Notifications
You must be signed in to change notification settings - Fork 77
Fix min kube version validation #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix min kube version validation #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kutluhanmetin Thanks for this contribution! These changes look good to me.
Would you mind updating the PR description to include a summary of the changes and the motivation for the changes? I'm aware of the context for this PR but other reviewers may not be so it would help them get up to speed before conducting their review :)
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 41.74% 41.94% +0.20%
==========================================
Files 39 39
Lines 3481 3488 +7
==========================================
+ Hits 1453 1463 +10
+ Misses 1881 1879 -2
+ Partials 147 146 -1
|
Added the description 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @kutluhanmetin, changes look good to me.
/lgtm
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, kutluhanmetin, oceanc80 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes operator-framework/operator-sdk#5995
operator-sdk bundle validate
passes all tests when CSV'sspec.minKubeVersion
with version formatx.y
. Howeverspec.minKubeVersion
with formatx.y
should be invalid because OLM refuses to deploy the CSV. Basically, this PR adds a validation methodvalidateMinKubeVersion
that validates if version format is in semantic versioningx.y.z
. So thatoperator-sdk bundle validate
fails before OLM refuses to deploy.