Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS#30001: Fix catalogsource typo for API docs #402

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

adellape
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from awgreene and jmrodri January 28, 2025 17:40
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.79%. Comparing base (1ed2691) to head (89ca2e7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   39.79%   39.79%           
=======================================
  Files          56       56           
  Lines        5450     5450           
=======================================
  Hits         2169     2169           
  Misses       3127     3127           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva
Copy link
Contributor

@adellape thank you! and sorry we missed this. When changing api documentation it is also important to update the generated files (make manifests generate format or just run make verify and add the new files, if safe to do so). I've gone ahead and done that for you and added the commit to the PR ^^

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adellape, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 29, 2025
Merged via the queue into operator-framework:master with commit b4021ba Jan 29, 2025
6 of 7 checks passed
@adellape
Copy link
Contributor Author

@perdasilva Ah yes, thank you! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants