Skip to content

fix(codegen): add doc.go in operators/v1 to support informer-gen #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

fix(codegen): add doc.go in operators/v1 to support informer-gen #56

merged 1 commit into from
Jul 31, 2020

Conversation

njhale
Copy link
Member

@njhale njhale commented Jul 31, 2020

  • fix broken informer-gen by adding doc.go file with the +groupName
    marker
  • remove unused internal types

@njhale
fix(codegen): add doc.go in operators/v1 to support informer-gen
16bd162 
- fix broken informer-gen by adding doc.go file with the +groupName
  marker
- remove unused internal types
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@njhale njhale mentioned this pull request Jul 31, 2020
Merged
@njhale njhale merged commit 6c81a47 into operator-framework:master Jul 31, 2020
@njhale njhale deleted the fix-codegen branch July 31, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ecordell ecordell

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njhale @ecordell @openshift-ci-robot